Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement graceful shutdown #57

Closed
alexandrebrg opened this issue Mar 20, 2023 · 1 comment · Fixed by #90
Closed

Implement graceful shutdown #57

alexandrebrg opened this issue Mar 20, 2023 · 1 comment · Fixed by #90
Assignees
Labels
scope/riklet type/enhancement New feature or request

Comments

@alexandrebrg
Copy link
Member

What needs to be done

  • Wait for a SIGKILL/SIGINT signal is received to trigger graceful shutdown1
  • Every runtime / component must have a method / capacity to kill what it has created (containers, VMs, iptables...)
  • Graceful shutdown should wait for all components to end their shutdown

Why it is needed

  • Riklet shutdown is not killing all containers / VMs created
  • Network management isn't deleting iptables on shutdown

Footnotes

  1. Learn more on tokio docs

@alexandrebrg alexandrebrg moved this to 🆕 New in RIK Tracking Mar 20, 2023
@kalil-pelissier kalil-pelissier self-assigned this Mar 20, 2023
@kalil-pelissier kalil-pelissier moved this from 🆕 New to 🏗️ In Progress in RIK Tracking Mar 20, 2023
@alexandrebrg alexandrebrg changed the title [riklet] Implement graceful shutdown Implement graceful shutdown Mar 28, 2023
@alexandrebrg
Copy link
Member Author

Hi @kalil-pelissier, the work done on instance deletion should be helpful for you as it gives you all the necessary methods to clean up workloads (#84)!

@kalil-pelissier kalil-pelissier mentioned this issue Apr 12, 2023
4 tasks
@github-project-automation github-project-automation bot moved this from 🏗️ In Progress to ✅ Done in RIK Tracking Apr 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
scope/riklet type/enhancement New feature or request
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

2 participants