Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct versioning for publishing multiple packages #507

Open
BatmanAoD opened this issue Oct 11, 2024 · 2 comments
Open

Correct versioning for publishing multiple packages #507

BatmanAoD opened this issue Oct 11, 2024 · 2 comments

Comments

@BatmanAoD
Copy link
Contributor

I think we need something like this: https://gitlab.com/rigetti/qcs/clients/qcs-api-client-rust/-/blob/main/knope.toml?ref_type=heads.


I wrote this to explain the problem, before I remembered we must have a solution in the qcs-api repo:

I think we also need to somehow split the Knope release for each package into separate steps, and I'm not sure whether Knope actually supports that. The simplest but most annoying solution might be to just prohibit making changes to both packages in a single PR. The sequence of events for a release is:

  • Knope updates both Cargo.toml files and the Cargo.lock file to have new package versions.
    • We could potentially add a script to update the python/Cargo.toml file's dependency on the core qcs package at this point, but we can't update the lockfile, because the updated version won't exist on crates.io yet.
  • Knope pushes git commit & tags.
  • Cargo publishes the lib crate.
  • Cargo publishes the python crate.

What we need is:

  • Knope updates the lib crate's Cargo.toml file and the lockfile.
  • Cargo publishes the lib crate.
  • A script runs that updates the python crate's dependency on the lib crate to the newly-published version.
  • Knope updates the python crate's Cargo.toml file and the lockfile.
  • Knope pushes git commit & tags.
@jselig-rigetti
Copy link
Contributor

As part of this, we should also update knope in the github actions to the latest version

@BatmanAoD
Copy link
Contributor Author

...also need to re-establish publishing the python package to crates.io

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants