fix(lib)!: clean up Error type variants, prefer error objects to strings #431
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Shadow53
force-pushed
the
427-better-errors
branch
from
53f38c2 to
a7b2105
Compare
| @@ -643,29 +621,18 @@ pub enum Error { | |||
| Compilation(String), | |||
| /// There was a problem when translating the Quil program. | |||
| #[error("There was a problem translating the Quil program: {0}")] | |||
| Translation(String), | |||
| Translation(GrpcClientError), | |||
There was a problem hiding this comment.
Many of the other errors look to be handled within QpuApiError now, which also has it's own variant with the same type QpuApiError::GrpcClientError(#[from] GrpcClientError)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #427. See #427 (comment) for why I did this instead of implementing retry logic.
There are a few main changes here, which all of which are API breaking:
QcsClienterror variant onqpu::execution::Errorwas only used for translation errors, so it was renamed to better communicate that.Translationvariant onexecutable::Errorwas unused, so I changed the inner type toGrpcClientErrorfromStringand changed conversion so the above error variant becomes this one.executable::Errorusing my editor'sFind All Referencesfeature and deleted anything that had no references.#[from], I removed that decorator to see if anything broke due to implicit conversions no longer working. Only the variants where this did not introduce errors were deleted.I'm open to restoring the unused variants and making them used, as appropriate. I figured that it would be good to clean things up while already making breaking changes.