Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fiber CSS classes need to be prefixed #180

Closed
ramonakira opened this issue May 22, 2013 · 2 comments
Closed

Fiber CSS classes need to be prefixed #180

ramonakira opened this issue May 22, 2013 · 2 comments

Comments

@ramonakira
Copy link
Contributor

To avoid conflicts, for example when using the "page"-class, Fiber should prefix all it's own classes, for example with "fbr-". The result would then be "fbr-page".

For example: in /fiber/static/fiber/js/admin.js on line 1426, function createLi sets the following classes: "page", "hidden-in-menu", "non-public", "redirect" and "non-editable". The CSS needs to be changed accordingly as well.
@antonpirker
Copy link

+1

@nvandijk
Copy link
Contributor

Fixed!
See commit 68e828f and b3cf939

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@antonpirker @nvandijk @ramonakira