Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ExcludeFiles doesn't check against contents of included subdirectory. #30

Open
dawnmist opened this issue Jul 1, 2019 · 0 comments
Open

Comments

@dawnmist
Copy link

dawnmist commented Jul 1, 2019

For the config:

const rpmOptions = {
  name: packageName,
  version: gitVersion.GitVersion,
  release: 1,
  buildArch: 'noarch',
  keepTemp: false,
  files: [{ cwd: './dist', src: '*', dest: `/opt/${packageName}/` }],
  excludeFiles: ['./dist/static/js/*.js.map']
};

My expected output would be that all files inside the ./dist directory and subdirectories should be checked against the exclude paths.

What actually happens is that the check stops at the level of the first subdirectory, i.e. the paths checked includes ./dist/static, and since that path is not itself in the excludeFiles the entire static subdirectory is included without checking any of the files within that directory against the excludeFiles list. i.e. all the *.js.map files inside the static/js subdirectory end up being added to the rpm instead of being excluded because those file paths never get tested against the excludeFiles list.

Tested on rpm_builder v1.1.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant