Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BC5: Using channels other than 0 and 1 (via rdo_bc_params::m_bc45_channelX) with RDO generates corrupted image #9

Open
shacklettbp opened this issue Apr 26, 2021 · 1 comment
Labels
bug Something isn't working

Comments

@shacklettbp
Copy link

The issue seems to be that the RDO code doesn't account for rdo_bc_params::m_bc45_channel0 or rdo_bc_params::m_bc45_channel1. The workaround is easy: I just permute the channels in my source image, but I wanted to report here in case other people run into this unawares.

Thank you very much for making an open source RDO compressor by the way!

@richgel999
Copy link
Owner

Thanks! I'll add a note or an assert.

@richgel999 richgel999 added the bug Something isn't working label Dec 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants