Invalid clearing of additional records

[eshvatskyi]

net-mdns/src/ServiceDiscovery.cs

Line 205 in cb3d0bd

if (response.Answers.Any(a => a.Name == ServiceName))

Should be

           // Many bonjour browsers don't like DNS-SD response
            // with additional records.
            if (response.Answers.Any(a => a.Name == ServiceName))
            {
               if (AnswersContainsAdditionalRecords)
               {
                   response.Answers.AddRange(response.AdditionalRecords);
               }
                response.AdditionalRecords.Clear();
            }

[richardschneider]

I agree, but the if (AnswersContainsAddditionalRecords) should be before the DNS-SD test.

Would you like to create a PR. This way you will get credit as a contributor!

[eshvatskyi]

I do, ) I have 1 optimization for DNS
and fix for mdns (using with multiple NIC)

[eshvatskyi]

Please let me know how I could create a PR

[richardschneider]

https://help.github.com/articles/creating-a-pull-request/

[eshvatskyi]

Lol )) I meant I dont have permissions ) to do this, should I fork it? or how to do this better?

[richardschneider]

Just make a fork of my repo. I noticed that you have done this but your fork is not current; just delete and re-fork. Make your changes. Finally you can submit by clicking new pull request.

You do not need any permissions on my repo.

[eshvatskyi]

Created 2 PRs, please check. not perfect ) but tested on multy Nics works perfect on windows 10 host.
Later will test on linux alpine. Missed implementation for AnswerAllQuestions, will add in case you interested in my PR

[richardschneider]

Does #40 resolve this issue?