feat: hires boundary #255
Merged
feat: hires boundary #255
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
antfu
approved these changes
Jul 27, 2023
antfu
reviewed
Jul 27, 2023
| * If sourcemap locations have been specified with s.addSourceMapLocation(), they will be used here. | ||
| */ | ||
| hires?: boolean; | ||
| hires?: boolean | 'boundary'; |
There was a problem hiding this comment.
Maybe word-boundary to be more specific? Not sure if we are going to have more different type of boundary tho
There was a problem hiding this comment.
I'm thinking a shorter name would make it easier to type out when using it. But open to other names too.
This was referenced Jul 28, 2023
JoostK
added a commit
to JoostK/angular-cli
that referenced
this pull request
Aug 6, 2023
… to word boundary magic-string 0.30.2 introduced [the `boundary` strategy][1] for its high-resolution source map mode, reducing the number of source map segments to align with word boundaries instead of having a segment per character. [1]: Rich-Harris/magic-string#255
dgp1130
pushed a commit
to angular/angular-cli
that referenced
this pull request
Aug 9, 2023
… to word boundary magic-string 0.30.2 introduced [the `boundary` strategy][1] for its high-resolution source map mode, reducing the number of source map segments to align with word boundaries instead of having a segment per character. [1]: Rich-Harris/magic-string#255
6 tasks
|
This PR is the next best thing since sliced bread. <3 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
hires: 'boundary'generates a segment for each word boundary, instead of for each character. Which should help:From twitter idea: https://twitter.com/dummdidumm_/status/1674102437890621454
Example sourcemap visualization