Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing icon on Linux #57

Closed
ukch opened this issue Jun 6, 2016 · 3 comments
Closed

Missing icon on Linux #57

ukch opened this issue Jun 6, 2016 · 3 comments

Comments

@ukch
Copy link

ukch commented Jun 6, 2016

I have seen the nyaovim icon, but on Linux NyaoVim has a default icon.

Screenshot on This Problem (if possible)

screenshot from 2016-06-06 11-55-13
(this is from the application bar, but the same problem occurs on the dock - using simple dock GNOME extension)

Your Environment

  • OS: Debian Sid
  • NyaoVim version: 0.0.19
  • nvim version: 0.1.3
  • Keyboard layout: UK
  • Linux: Window manager: GNOME 3.20.2
@rhysd
Copy link
Owner

rhysd commented Aug 10, 2016

In Linux, how to show icon is depending on desktop environment (e.g. in you environment, it looks GNOME). So, it's hard to setup an app icon in all environments because I don't know how to do that.

@ukch
Copy link
Author

ukch commented Sep 27, 2016

Hi, according to electron/packager#128 this can be done by passing the icon argument to BrowserWindow, e.g.:

new BrowserWindow({icon: NativeImage.createFromPath("/path/to/icon.png")})

@rhysd
Copy link
Owner

rhysd commented Sep 27, 2016

Nice! I'll add icon to window.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants