You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I noticed this when I had a class that was a default export. So I wrote a test to try to debug it. Here's the behavior I got
Does anyone have any idea why this is happening and how can I fix it? I'd be more than happy to make a pr for this.
Also, what are people's thoughts on splitting the currently massive index.ts file into multiple smaller files. I think that'll make code navigation significantly easier. Also happy to make a pr for this.
The text was updated successfully, but these errors were encountered:
Does anyone have any idea why this is happening and how can I fix it? I'd be more than happy to make a pr for this.
Not off the top of my head. The default export should be the camel cased name of the file and should not error. It's possible that this is caused by an upstream error. Kind of surprised we never added tests for a default export.
Also, what are people's thoughts on splitting the currently massive index.ts file into multiple smaller files. I think that'll make code navigation significantly easier. Also happy to make a pr for this.
Yeah, I think if there are any individual helpers that are convenient to split out that would be a good place to start. Some of the functions take way too many arguments too. I can imagine a refactor where we have one object that is the file builder and has functions like "add function" "add constant" etc etc, and the actual type checking logic is elsewhere.
I'm a little apprehensive to give the green light in case I don't like the refactor, but I think some initial steps in that direction would be good. Please do the refactoring as a separate PR though. Perhaps fix this issue first then refactor after?
I noticed this when I had a class that was a default export. So I wrote a test to try to debug it. Here's the behavior I got
Does anyone have any idea why this is happening and how can I fix it? I'd be more than happy to make a pr for this.
Also, what are people's thoughts on splitting the currently massive index.ts file into multiple smaller files. I think that'll make code navigation significantly easier. Also happy to make a pr for this.
The text was updated successfully, but these errors were encountered: