Extend container-uefi with fix for vconsole keymap

[jkonecny12]

It is fix for
https://bugzilla.redhat.com/show_bug.cgi?id=1890085 https://issues.redhat.com/browse/INSTALLER-2537

Currently, virtual console is not correctly set from localed on an ostree installations. To resolve this issue let's put the vconsole.keymap to the installed system kernel arguments.

Depends on rhinstaller/anaconda#5952

[jkonecny12]

/test-tmt

[jkonecny12]

Expected to fail without the PR but I want to verify that behavior.

[rvykydal]

I am wondering why the test called from the Anaconda PR (rhinstaller/anaconda#5952 (comment)) failed.

2024-10-21 13:53:25,527 DEBUG: Running command: ['/opt/kstest/kickstart-tests/scripts/launcher/lib/launcher_interface.sh', '-i', '/opt/kstest/data/images/boot.iso', '-k', '1', '-w', '/var/tmp/kstest-rpm-ostree-container-uefi.2024_10_21-13_50_02.24lg01k4', '-t', '/opt/kstest/kickstart-tests/rpm-ostree-container-uefi.sh', 'validate']
2024-10-21 13:53:42,621 DEBUG: Failed to run subprocess: '['/opt/kstest/kickstart-tests/scripts/launcher/lib/launcher_interface.sh', '-i', '/opt/kstest/data/images/boot.iso', '-k', '1', '-w', '/var/tmp/kstest-rpm-ostree-container-uefi.2024_10_21-13_50_02.24lg01k4', '-t', '/opt/kstest/kickstart-tests/rpm-ostree-container-uefi.sh', 'validate']'
stdout:
*** System has started with errors:
Oct 21 09:53:12 fedora kernel: Command line: BOOT_IMAGE=(hd0,gpt2)/ostree/test-stateroot-9973686baa6bc2238914566415b91a60f83ae946d9891b8fcdd4788a0ee974b2/vmlinuz-6.12.0-0.rc3.20241015giteca631b8fe80.32.fc42.x86_64 rd.lvm.lv=fedora_ibm-p8-kvm-03-guest-02/root root=UUID=4d4c56e7-b054-4bb2-9104-f6f40cc7bf2e vconsole.keymap=us rw ostree=/ostree/boot.0/test-stateroot/9973686baa6bc2238914566415b91a60f83ae946d9891b8fcdd4788a0ee974b2/0
Oct 21 09:53:12 fedora kernel: Kernel command line: BOOT_IMAGE=(hd0,gpt2)/ostree/test-stateroot-9973686baa6bc2238914566415b91a60f83ae946d9891b8fcdd4788a0ee974b2/vmlinuz-6.12.0-0.rc3.20241015giteca631b8fe80.32.fc42.x86_64 rd.lvm.lv=fedora_ibm-p8-kvm-03-guest-02/root root=UUID=4d4c56e7-b054-4bb2-9104-f6f40cc7bf2e vconsole.keymap=us rw ostree=/ostree/boot.0/test-stateroot/9973686baa6bc2238914566415b91a60f83ae946d9891b8fcdd4788a0ee974b2/0
Oct 21 09:53:12 fedora dracut-cmdline[341]: Using kernel command line parameters:  rd.driver.pre=btrfs   BOOT_IMAGE=(hd0,gpt2)/ostree/test-stateroot-9973686baa6bc2238914566415b91a60f83ae946d9891b8fcdd4788a0ee974b2/vmlinuz-6.12.0-0.rc3.20241015giteca631b8fe80.32.fc42.x86_64 rd.lvm.lv=fedora_ibm-p8-kvm-03-guest-02/root root=UUID=4d4c56e7-b054-4bb2-9104-f6f40cc7bf2e vconsole.keymap=us rw ostree=/ostree/boot.0/test-stateroot/9973686baa6bc2238914566415b91a60f83ae946d9891b8fcdd4788a0ee974b2/0

2024-10-21 13:53:42,622 INFO: RESULT:rpm-ostree-container-uefi:d713234fd2c0:FAILED:Validation failed with return code 1

[jkonecny12]

Honestly not sure but it looks that the issue was in my changes. With the newest changes it looks fixed locally.

Maybe that grep without -q is propagating somehow into the RESULTS file?

[jkonecny12]

/test-tmt

[jkonecny12]

/test-tmt

[rvykydal]

/test-os-variants

[jkonecny12]

The test-os-variants won't work because my patch was just merged so it is not yet part of the Rawhide. Do we want to wait for the release?

[rvykydal]

The test-os-variants won't work because my patch was just merged so it is not yet part of the Rawhide. Do we want to wait for the release?

Maybe let's wait for daily-iso and merge?

[jkonecny12]

I see even the TMT is using Rawhide ISO. In that case we should probably wait for release. That is a pain honestly.

[rvykydal]

I see even the TMT is using Rawhide ISO. In that case we should probably wait for release. That is a pain honestly.

In general I'd be OK for merging just with

• the test passing on the Anaconda PR (/kickstart-test --kstest-pr 1323 rpm-ostree-container-uefi) to see it is actually working, and
• the PR passing /test/os/variants to the extent it does not break daily tests (that means passing every variant we run in dailies - so rawhide not required). Waiting for daily-iso should be usually 1 day after merge so it seems fine to me.

[rvykydal]

/test-os-variants

[rvykydal]

/test-os-variants

[jkonecny12]

/test-tmt

[jkonecny12]

Not blocked anymore. Changes are part of Rawhide now. @rvykydal could you please do a review of this PR?

[rvykydal]

Looks good to me.