Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable RDP test on Fedora #1309

Merged
merged 1 commit into from
Nov 13, 2024
Merged

Enable RDP test on Fedora #1309

merged 1 commit into from
Nov 13, 2024

Conversation

jkonecny12
Copy link
Member

It was implemented by rhinstaller/anaconda#5829

@jkonecny12 jkonecny12 added the blocked This can't be merged before dependencies! label Sep 24, 2024
@jkonecny12
Copy link
Member Author

Tested by https://github.com/rhinstaller/anaconda/actions/runs/11017713395/job/30596297336

@jkonecny12
Copy link
Member Author

/test-tmt

@jkonecny12 jkonecny12 removed the blocked This can't be merged before dependencies! label Oct 10, 2024
@rvykydal
Copy link
Contributor

/test-tmt

@rvykydal
Copy link
Contributor

/test-os-variants

@rvykydal
Copy link
Contributor

/test-tmt

06:40:06,736 ERR anaconda:Traceback (most recent call last):
06:40:06,736 ERR anaconda:  File "/usr/lib64/python3.13/site-packages/pyanaconda/core/threads.py", line 280, in run
06:40:06,736 ERR anaconda:    threading.Thread.run(self)
06:40:06,736 ERR anaconda:    ~~~~~~~~~~~~~~~~~~~~^^^^^^
06:40:06,736 ERR anaconda:  File "/usr/lib64/python3.13/threading.py", line 992, in run
06:40:06,736 ERR anaconda:    self._target(*self._args, **self._kwargs)
06:40:06,736 ERR anaconda:    ~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
06:40:06,736 ERR anaconda:  File "/usr/lib64/python3.13/site-packages/pyanaconda/gnome_remote_desktop.py", line 173, in _get_hostname_in_thread
06:40:06,736 ERR anaconda:    hinfo = socket.gethostbyaddr(ip)
06:40:06,736 ERR anaconda:TypeError: gethostbyaddr() argument 1 must be str, bytes or bytearray, not None

@KKoukiou
Copy link
Contributor

KKoukiou commented Nov 1, 2024

@jkonecny12 can you check this when you have time #1309 ?

@M4rtinK
Copy link
Contributor

M4rtinK commented Nov 1, 2024

Looks like it found something, cool. :)

@jkonecny12 jkonecny12 force-pushed the master-enable-rdp-test-on-fedora branch from 5a9cde5 to 2ffdc46 Compare November 12, 2024 15:14
@jkonecny12
Copy link
Member Author

Added code to avoid stopping the test on Gdk known error.

@jkonecny12
Copy link
Member Author

/test-tmt

@jkonecny12
Copy link
Member Author

/test-tmt

06:40:06,736 ERR anaconda:Traceback (most recent call last):
06:40:06,736 ERR anaconda:  File "/usr/lib64/python3.13/site-packages/pyanaconda/core/threads.py", line 280, in run
06:40:06,736 ERR anaconda:    threading.Thread.run(self)
06:40:06,736 ERR anaconda:    ~~~~~~~~~~~~~~~~~~~~^^^^^^
06:40:06,736 ERR anaconda:  File "/usr/lib64/python3.13/threading.py", line 992, in run
06:40:06,736 ERR anaconda:    self._target(*self._args, **self._kwargs)
06:40:06,736 ERR anaconda:    ~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
06:40:06,736 ERR anaconda:  File "/usr/lib64/python3.13/site-packages/pyanaconda/gnome_remote_desktop.py", line 173, in _get_hostname_in_thread
06:40:06,736 ERR anaconda:    hinfo = socket.gethostbyaddr(ip)
06:40:06,736 ERR anaconda:TypeError: gethostbyaddr() argument 1 must be str, bytes or bytearray, not None

I wasn't able to reproduce this issue :(

rvykydal
rvykydal approved these changes Nov 13, 2024
View reviewed changes
Copy link
Contributor

@rvykydal rvykydal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thank you!

@rvykydal
Copy link
Contributor

/test-os-variants

@jkonecny12 jkonecny12 merged commit a41f6a0 into rhinstaller:master Nov 13, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KKoukiou KKoukiou KKoukiou approved these changes

@rvykydal rvykydal rvykydal approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jkonecny12 @rvykydal @KKoukiou @M4rtinK