Tests for kickstart script commands

[adamkankovsky]

Tests for PR: rhinstaller/anaconda#5739

[adamkankovsky]

/test-tmt

[rvykydal]

/test-os-variants

[rvykydal]

This is great work, thank you!
I have some suggestions regarding naming, metadata and reusing:

• I'd rather make all the tests of a common TESTTYPE, something like ksscript or script so that it is easy to run them together (like in the anaconda PR: /kickstart-test --kstest-pr 1302 --testtype ksscript)
• I'd name the tests with common prefix, like script-pre instead of pre-script
• I think we can use fragments (%ksinclude) more, like in ui_text_interactive. This can be done as a follow-up though.

[rvykydal]

Thanks for using the fragments (like %ksappend common/common_no_payload.ks) but is seems incomplete to me.

[rvykydal]

/test-os-variants

[rvykydal]

/test-tmt

[rvykydal]

The update looks good to me, however

• one test is failing on testing farm, not sure why
• the tests are not run in permian (on /test-os-variants)) because of the .sh files not being executable (

  kickstart-tests/scripts/generate-testcases.py

  Line 72 in 85f0856

  if not os.access(filepath, os.X_OK):

  , example of a test making executable: 51d6ecb). Sorry for this non-transparent requirement.

[adamkankovsky]

/test-os-variants

[adamkankovsky]

/test-tmt

[adamkankovsky]

/test-os-variants

[adamkankovsky]

/test-tmt

[adamkankovsky]

/test-tmt

[adamkankovsky]

/test-os-variants

[adamkankovsky]

/test-tmt

[adamkankovsky]

/test-os-variants

[adamkankovsky]

/test-tmt

[rvykydal]

Looks good to me, great job, thank you.