From a6698ba899e6900ffbb8aea10e97b075e24a5b05 Mon Sep 17 00:00:00 2001 From: Radek Vykydal Date: Tue, 21 May 2024 09:19:05 +0200 Subject: [PATCH 1/2] Update documentation for test-os-variants The reason: - be honest that we just really test changed tests (not affected, i no inference here) - I think the "to specify tests to run or test to be skipped" doesn't help to clear up the options in the usage below, so rather let user to figure it out from the usage or add more examples (in a separate PR). - Make clear that the dry mode can be used for any usage (including the explicit options) --- .github/workflows/test-os-variants.yml | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/.github/workflows/test-os-variants.yml b/.github/workflows/test-os-variants.yml index 3db5db78..3196321f 100644 --- a/.github/workflows/test-os-variants.yml +++ b/.github/workflows/test-os-variants.yml @@ -1,18 +1,18 @@ # Run kickstart tests in a PR triggered by a "/test-os-variants" command from an organization member # -# To run all tests affected by the PR (or just smoke tests if the PR changes no tests) +# To run all tests changed in the PR (or just smoke tests if the PR changes no tests) # use this in a PR comment: # # /test-os-variants # -# Alternatively it is also possible to specify tests to run or test to be skipped: +# Alternatively it is also possible to specify tests to run explicitly: # # /test-os-variants --testtype TESTTYPE --skip-testtypes TYPE[,TYPE..] TEST1 TEST2 # # Lastly there is a dry-run mode, that just indicates which tests would be run # (useful to check test grouping and overall infra health): # -# /test-os-variants-dry +# /test-os-variants-dry ... # # name: test-os-variants From 1e25fdcf19c4dc80ea20726de4f859f08e727902 Mon Sep 17 00:00:00 2001 From: Radek Vykydal Date: Tue, 21 May 2024 09:29:59 +0200 Subject: [PATCH 2/2] Add examples to test-os-variants GH workflow doc --- .github/workflows/test-os-variants.yml | 19 +++++++++++++++++++ 1 file changed, 19 insertions(+) diff --git a/.github/workflows/test-os-variants.yml b/.github/workflows/test-os-variants.yml index 3196321f..7c5a5604 100644 --- a/.github/workflows/test-os-variants.yml +++ b/.github/workflows/test-os-variants.yml @@ -5,10 +5,29 @@ # # /test-os-variants # +# # Alternatively it is also possible to specify tests to run explicitly: # # /test-os-variants --testtype TESTTYPE --skip-testtypes TYPE[,TYPE..] TEST1 TEST2 # +# Examples: +# +# /test-os-variants keyboard lang +# ... run the tests specified by names (space separated) +# +# /test-os-variants --skip-testtypes gh123,gh765 keyboard lang +# ... run the tests specified by names while skipping tests with given types (comma separated) +# +# /test-os-variants --testtype network +# ... run all the tests of type network +# +# /test-os-variants --testtype network --skip-testtypes gh123,gh765 +# ... run all the tests of type network while skipping tests with given types (comma separated) +# +# /test-os-variants --skip-testtypes gh123,gh765 +# ... run all the tests while skipping tests with given types (comma separated) +# +# # Lastly there is a dry-run mode, that just indicates which tests would be run # (useful to check test grouping and overall infra health): #