-
Notifications
You must be signed in to change notification settings - Fork 788
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Bug] code block contrast in white-mode extremly low #364
Comments
+1'ing this one. EDIT: hugo-theme-hello-friend-ng/assets/scss/_main.scss Lines 213 to 239 in 959421d
hugo-theme-hello-friend-ng/assets/scss/_main.scss Lines 260 to 284 in 959421d
|
Hello there,
first, lots of thanks for the amazing work with the great theme! :D
Now to an unwanted behavior I realized today:
In white mode the code inside the ```-code box is covered by the light-background color which makes the text barely unreadable.
With the single-quote `-code this doesn't happen, nor in dark mode.
EDIT: Seems to have something to do with the
code {}
-section in assets/scss/_main.scss.EDIT 2:
(1)
assets/scss/_main.scss
:Replacing
color: #ccc;
withcolor: inherit;
here:fixes the issue.
Because
inherit
seems to be the default value for the text-color, just removing this whole code block (1) fixes the issue as well.I'm not sure how it's actually meant to be. Either you would have to change the text color for both types of code blocks (as block code and as inline code) or use inherit for both.
I would suggest the solution with removing the lines, since I successfully tested it, and if it is meant differently(?), then you would have to fix it differently ...
The text was updated successfully, but these errors were encountered: