Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

does not work anymore #2

Closed
idnovic opened this issue Jun 29, 2019 · 7 comments
Closed

does not work anymore #2

idnovic opened this issue Jun 29, 2019 · 7 comments

Comments

@idnovic
Copy link

idnovic commented Jun 29, 2019

Fedora 30
I installed the extension and in the menu I can just see Error occurred when fetching containers
I looked at the source code and found 1 error:

#$podman ps -a --format '{{json .}}'
Error: template: data:1: function "json" not defined

but podman ps -a --format '{{.}}' works

Still the extension does not work before and after I made the change. I would appreciate it, when you would fix the extension.

@rgolangh
Copy link
Owner

rgolangh commented Jun 30, 2019

This was reported here under podman and looks like this should be back working with latest podman version.
I'll try to see if I can handle it in a different format meanwhile.

@rgolangh
Copy link
Owner

rgolangh commented Jul 1, 2019

Fixes under the branch https://github.com/rgolangh/gnome-shell-extension-containers/tree/fedora-30

Extension uploaded for review and will be available in few days if everything goes well.

@idnovic
Copy link
Author

idnovic commented Jul 1, 2019

Thank you. Seems to work now. Still need to test it for the functionality :)

@rgolangh
Copy link
Owner

rgolangh commented Jul 1, 2019

Awesome, thanks for using and reporting the issue.

BTW I'd love to get more suggestions for any enhancements or changes, feel free to open more issues.

@idnovic
Copy link
Author

idnovic commented Jul 1, 2019

So I tried to record it, following problem (you can see it in the gif just the top bar is missing)
The menu moves to the left because screen space is missing on the right side. The gif is at the top most right corner. Just a few pixel missing for the top bar.

What happens is that after I close a menu the extension moves left. But the icon in the top bar stays at the position of the first frame in the gif.
Peek 2019-07-01 09-19

@rgolangh
Copy link
Owner

rgolangh commented Jul 1, 2019

Fixed, can you check the latest fedora-30 branch?

@idnovic
Copy link
Author

idnovic commented Jul 1, 2019

yes awesome. Much better :)

@idnovic idnovic closed this as completed Jul 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants