Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create svd_wrapper and copy ginv to avoid LAPACK errors #83

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

GFabien
Copy link
Collaborator

@GFabien GFabien commented May 5, 2024

Wrap the calls to the svd function in the RGCCA package into the svd_wrapper function to avoid LAPACK errors as done in the JIVE package. SVD are performed in RGCCA in the block initializations (when init = TRUE) and through the calls to the MASS::ginv function. Therefore, this last function has been reimplemented in the package and calls the wrapper instead of the original SVD function.

Aims to solve #82.

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 68.42105% with 18 lines in your changes are missing coverage. Please review.

Project coverage is 94.56%. Comparing base (eefad3b) to head (fa8b370).

Current head fa8b370 differs from pull request most recent head be97b1b

Please upload reports for the commit be97b1b to get more accurate results.

Files Patch % Lines
R/svd_wrapper.R 47.36% 10 Missing ⚠️
R/ginv.R 71.42% 4 Missing ⚠️
R/block_project.R 75.00% 3 Missing ⚠️
R/deflation.R 80.00% 1 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #83      +/-   ##
==========================================
- Coverage   95.02%   94.56%   -0.47%     
==========================================
  Files          80       82       +2     
  Lines        3138     3185      +47     
==========================================
+ Hits         2982     3012      +30     
- Misses        156      173      +17     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants