Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove new HTML template #94

Closed
wants to merge 1 commit into from
Closed

Remove new HTML template #94

wants to merge 1 commit into from

Conversation

dgkeyes
Copy link
Member

@dgkeyes dgkeyes commented Jan 15, 2025

This PR removes the new HTML template created in #89.

@OskaratOmni please install with:

remotes::install_github("rfortherestofus/omni", force = TRUE, ref = "93-remove-html-template")

Let me know if it works for you after that. Once you confirm I'll merge the PR.

@dgkeyes dgkeyes linked an issue Jan 15, 2025 that may be closed by this pull request
@dgkeyes dgkeyes requested a review from OskaratOmni January 24, 2025 18:00
@OskaratOmni
Copy link
Collaborator

Hey David, this actually didn't work for me. I still see the template there. I ran it in one R session and restarted R and it was still there. I did that twice.
But, I don't think we need to try too hard to remove it. I put a note on our slack channel letting people know that the previous versions work better. And if someone tries to knit with this it is completely un-formatted so they will realize pretty quick that something is up.

Copy link
Member Author

dgkeyes commented Jan 28, 2025

Ok, sounds good! I'll close the PR but we can open it up in the future if necessary.

@dgkeyes dgkeyes closed this Jan 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove new HTML template
2 participants