Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ggplot gallery: lollipop edits #72

Open
OskaratOmni opened this issue Jan 12, 2024 · 1 comment
Open

ggplot gallery: lollipop edits #72

OskaratOmni opened this issue Jan 12, 2024 · 1 comment
Assignees
Labels
documentation Improvements or additions to documentation

Comments

@OskaratOmni
Copy link
Collaborator

Reviewer comments:

Add a title

Make the dot large enough that the number can fit inside it

Can we add an option to change certain bar colors or add a vertical line for a benchmark if needed?

@tvroylandt tvroylandt added the documentation Improvements or additions to documentation label Jan 17, 2024
@dgkeyes dgkeyes self-assigned this Jan 17, 2024
@dgkeyes
Copy link
Member

dgkeyes commented Jan 17, 2024

I've done all of this. See https://stupendous-biscuit-9f1c75.netlify.app/ggplot/graph_lollipop.html

The only thing I haven't changed is adding instructions to change certain bar colors. This is a general thing that is covered on the guidelines page. While we could show it for each bar chart type, it becomes quite duplicative.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

No branches or pull requests

3 participants