Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Log-linear GDP Interpolation #12

Closed
lrennels opened this issue Nov 1, 2021 · 5 comments
Closed

Log-linear GDP Interpolation #12

lrennels opened this issue Nov 1, 2021 · 5 comments

Comments

@lrennels
Copy link
Collaborator

lrennels commented Nov 1, 2021

@bryanparthum as you brought up, perhaps this should be log-linear, I am discussing with @bprest now

@bryanparthum
Copy link
Collaborator

Thanks. I attempted it here last week but I don't know enough about LinearInterpolation to do it right and I think it's off. In addition to needing to improve my understanding of workflow for testing modifications across packages :-)

@lrennels
Copy link
Collaborator Author

lrennels commented Nov 1, 2021

@bryanparthum oh nice I think this is actually correct, I'll double check this afternoon though. To test modifications across packages you can dev multiple into your environment, but I'm with you that that can get confusing because it means you have to manually make sure multiple packages are on the right version at once so I avoid it (@davidanthoff devs a bunch at a time but he's a pro).

Can you make that a PR on this package? Turns out I can edit your forks with the VSCode extension so I can double check it and then do the version control updating and have it to you by this afternoon.

@bryanparthum
Copy link
Collaborator

Sure thing. Okay great, I was just deving both, so if that's how it supposed to be done then that's reassuring.

@lrennels
Copy link
Collaborator Author

lrennels commented Nov 1, 2021

Yep that should work! Once we merge this you can un-dev

@lrennels
Copy link
Collaborator Author

lrennels commented Nov 2, 2021

Closing! Done!

@lrennels lrennels closed this as completed Nov 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants