fix: ava ci #23
Merged
fix: ava ci #23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
The testing pipeline began to fail following the release of new node version 18.19. This version included breaking changes such as deprecating the experimental
--loaderflag which was being relied on in the configuration foravatests.Specifically, we were supplying the node arguments
--loader=tsxto compile .ts files to JS before executing tests.With the removal of this flag,
tsxpackage has since been updated here (privatenumber/tsx#422) to support usage via the--importflag instead.Furthermore, based on inspiration from this issue(TypeStrong/ts-node#935 (comment)) and digging through ava docs, I was inspired to update the
extensionsconfiguration to just specify"ts".Finally since
--importis not supported by Node 16, which has also reached EOL, I have updated the CI workflow to test for 18 and 20.Finally, updated the pnpm version in the workflow to get past this issue(pnpm/pnpm#6424)