Skip to content

Commit

Permalink
Merge pull request mediaelement#335 from jmcneese/volume-slider-offse…
Browse files Browse the repository at this point in the history
…t-fix

added check for left offset to detect when mousedrag exceeds top boundar...
  • Loading branch information
johndyer committed Dec 28, 2011
2 parents 31d0648 + 4d9a319 commit a7b23fa
Show file tree
Hide file tree
Showing 5 changed files with 7 additions and 7 deletions.
2 changes: 1 addition & 1 deletion build/mediaelement-and-player.js
Original file line number Diff line number Diff line change
Expand Up @@ -2916,7 +2916,7 @@ if (typeof jQuery != 'undefined') {
volume = (railHeight - newY) / railHeight

// the controls just hide themselves (usually when mouse moves too far up)
if (totalOffset.top == 0)
if (totalOffset.top == 0 || totalOffset.left == 0)
return;

// 0-1
Expand Down
4 changes: 2 additions & 2 deletions build/mediaelement-and-player.min.js

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion build/mediaelementplayer.js
Original file line number Diff line number Diff line change
Expand Up @@ -1437,7 +1437,7 @@ if (typeof jQuery != 'undefined') {
volume = (railHeight - newY) / railHeight

// the controls just hide themselves (usually when mouse moves too far up)
if (totalOffset.top == 0)
if (totalOffset.top == 0 || totalOffset.left == 0)
return;

// 0-1
Expand Down
4 changes: 2 additions & 2 deletions build/mediaelementplayer.min.js

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion src/js/mep-feature-volume.js
Original file line number Diff line number Diff line change
Expand Up @@ -65,7 +65,7 @@
volume = (railHeight - newY) / railHeight

// the controls just hide themselves (usually when mouse moves too far up)
if (totalOffset.top == 0)
if (totalOffset.top == 0 || totalOffset.left == 0)
return;

// 0-1
Expand Down

0 comments on commit a7b23fa

Please sign in to comment.