-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments in rule sets for variable definitions #34
Comments
Posted this as segmentio/myth#99 yesterday, but this probably belongs here. |
Pretty much any half-decent minfier will strip those rules out. |
Sure, but I actually don't want to minify/compress the file. I was hoping that if rework-vars removes empty rule sets without comments, it could also remove empty rule sets with comments. Not that big of a problem though, @necolas. |
That behaviour is the result of reworkcss/css. I think it kind of makes sense not to strip rules with comments in them, because you might want to do something with those comments in a css preprocessor. |
Unlikely but yeah, who knows! :) I'd say that these comments almost ever belong to the anyhow stripped out variable definitions. |
All
:root {}
rule sets with variable definitions are generally removed from the output. But not so if they contain comments. Aiming for a clean CSS file, I'd like to have an option to have these sets (and the comments) removed, too.The text was updated successfully, but these errors were encountered: