Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

assertGoodView seems to expect an url_name as param but it never reverses it #202

Open
nessita opened this issue May 18, 2023 · 1 comment

Comments

@nessita
Copy link
Contributor

nessita commented May 18, 2023

The current signature of assertGoodView looks like this:

    def assertGoodView(self, url_name, *args, **kwargs):

but the implementation never reverses the url_name param so a valid url name results in a 404 instead of a 400.

@nessita
Copy link
Contributor Author

nessita commented May 18, 2023

OTOH, assertLoginRequired has this signature:

    def assertLoginRequired(self, url, *args, **kwargs):

but it forcibly calls reverse on URL, which fails if you pass the resolved url! 😕

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant