master promotion
#164
Open
master promotion
#164
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mrjackv
force-pushed
the
feature/master-promotion
branch
2 times, most recently
from
50fb3fe to
2544129
Compare
mrjackv
force-pushed
the
feature/master-promotion
branch
8 times, most recently
from
1b444cc to
ea2f20a
Compare
Inline parts of the s3cmd config which are not auth-specific or bucket-specific.
mrjackv
force-pushed
the
feature/master-promotion
branch
from
ea2f20a to
16ffd58
Compare
mrjackv
force-pushed
the
feature/master-promotion
branch
4 times, most recently
from
05e5c53 to
afabd7d
Compare
Add additional information when failing in the mass-testing-regression component.
Sync the `.gitlab-ci.yml` back from the gitlab CI repo.
Introduce the `ci-regression.sh` script, which will be used for regression testing and promoting the `develop` branch to `master`.
mrjackv
force-pushed
the
feature/master-promotion
branch
from
afabd7d to
23ee577
Compare
|
I think we need a brief |
| # 1: | ||
| # File containing the list of changed files in the binary archives, each line | ||
| # is a different file path | ||
| # COMPONENT_TARGET_BRANCH: target branch the CI has been triggered against |
| @@ -7,6 +7,11 @@ set -euo pipefail | |||
| # | |||
| # Mandatory parameters: | |||
| # | |||
| # 1: | |||
There was a problem hiding this comment.
./binary-archives-hook.sh CHANGED_FILES
CHANGED_FILES
File containing the list of changed files in the binary archives, each line
is a different file path
Environment variables:
COMPONENT_TARGET_BRANCH: target branch the CI has been triggered against
[...]
Same elsewhere, the environment variables are list under "parameters", which is confusing.
Also, please document in the header what this script does. It only explains when it runs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sister PRs:
gitlab/revng/orchestra