Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add to m2e discovery catalog #30

Open
kwin opened this issue Aug 18, 2020 · 5 comments
Open

Add to m2e discovery catalog #30

kwin opened this issue Aug 18, 2020 · 5 comments

Comments

@kwin
Copy link

kwin commented Aug 18, 2020

This m2e extension should be added to https://github.com/takari/m2e-discovery-catalog to be able to automatically install this once the formatter-maven-plugin is detected.

@ctubbsii
Copy link
Member

This m2e extension should be added to https://github.com/takari/m2e-discovery-catalog to be able to automatically install this once the formatter-maven-plugin is detected.

I agree that it would be great to automatically discover and install this, but I don't know enough about this ecosystem to make it happen. Any chance you can help, @kwin ?

@kwin
Copy link
Author

kwin commented Aug 18, 2020

A prerequisite for this is a p2 update site from where the extension could be installed (#1). Once that is in place I can help creating a PR for the discovery catalog.

@ctubbsii
Copy link
Member

@kwin Do you know if the Takari discovery catalog is the only way to get automatically discovered? Is there any way for the formatter plugin itself to define enough metadata for discovery on its own?

@kwin
Copy link
Author

kwin commented Aug 18, 2020

Is there any way for the formatter plugin itself to define enough metadata for discovery on its own?

This is not called discovery then, but sure you can integrate m2e support in the plugin as well: https://www.eclipse.org/m2e/documentation/m2e-execution-not-covered.html

@ctubbsii
Copy link
Member

Is there any way for the formatter plugin itself to define enough metadata for discovery on its own?

This is not called discovery then, but sure you can integrate m2e support in the plugin as well: https://www.eclipse.org/m2e/documentation/m2e-execution-not-covered.html

I think we want to Delegate to a Project Configurator (recommended) on that page, but the link in that section for how to do that is broken. We have some metadata already defined in the formatter plugin, but I don't know the syntax. I assume that either:

  1. it defines only the configurator to delegate to, but not where to locate it, and you need to add the configurator to the discovery catalog for it to find it, or
  2. it can define the configurator to delegate to, and also the URL at which to find it.

Based on this conversation and my previous investigations into this, I think the first option is the only way this can work, but since the link is broken, I don't know where to look for the full syntax of the configurator in the metadata: https://github.com/revelc/formatter-maven-plugin/blob/main/src/main/resources/META-INF/m2e/lifecycle-mapping-metadata.xml#L26-L34

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants