Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Input still recognized while out of focus #36

Closed
rsubtil opened this issue Sep 27, 2022 · 2 comments
Closed

Input still recognized while out of focus #36

rsubtil opened this issue Sep 27, 2022 · 2 comments
Labels
bug Something isn't working priority topic:core Issues or pull requests related to RetroHub itself

Comments

@rsubtil
Copy link
Member

rsubtil commented Sep 27, 2022

RetroHub is still picking up joystick input when the app is out of focus. This is problematic as it can change settings in the background and mess things up without the user noticing. Input should only be accepted when the app is focused (this is not an issue with keyboard/mouse as the OS manages app focus instead)

@rsubtil rsubtil added bug Something isn't working topic:core Issues or pull requests related to RetroHub itself labels Sep 27, 2022
@rsubtil rsubtil added this to the First Beta milestone Sep 27, 2022
@rsubtil
Copy link
Member Author

rsubtil commented Oct 8, 2022

This may require changes in Godot due to UI events. There's godotengine/godot#16832 which points to a commit that might be easily cherry-pickable.

For now, it might be sufficient to handle this in code and avoid opening UI elements when out-of-focus. This however might not solve all issues if there's existing UI elements. A solution will be tried, but if more issues arise of this, it's better to patch Godot altogether.

@rsubtil
Copy link
Member Author

rsubtil commented Jan 6, 2023

Fixed with c7dad04

@rsubtil rsubtil closed this as completed Jan 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working priority topic:core Issues or pull requests related to RetroHub itself
Projects
None yet
Development

No branches or pull requests

1 participant