Fix lazy currentUser #586
Merged
Fix lazy currentUser #586
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
June 13, 2016 17:32
| @@ -355,3 +356,39 @@ export class Limit extends TermBase { | |||
| super(sendRequest, query, []) | |||
| } | |||
| } | |||
|
|
|||
|
|
|||
| export class UserDataTerm { | |||
There was a problem hiding this comment.
This is just moved from index.js where it didn't really belong
deontologician
added a commit
that referenced
this pull request
Jun 14, 2016
* currentUser now will force a handshake Fixes #567 * Add handshake to utensils
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #567
The issue was that subscribing to the handshake doesn't force a connection, it only sets a callback whenever the handshake happens to be completed. Now, when subscribing
currentUser().fetch()orcurrentUser.watch()an actual connection will be made.This change is