Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problem with connectedhomeip restyler job #3200639 #205

Closed
bzbarsky-apple opened this issue May 22, 2023 · 7 comments
Closed

Problem with connectedhomeip restyler job #3200639 #205

bzbarsky-apple opened this issue May 22, 2023 · 7 comments

Comments

@bzbarsky-apple
Copy link

See https://restyled.io/gh/project-chip/repos/connectedhomeip/jobs/3200639 and https://restyled.io/gh/project-chip/repos/connectedhomeip/jobs/3200639/log

It looks like the restyler crashed (ran out of memory? Something else?).

@pbrisbin
Copy link
Member

This may be a repeat of #194. Let me rotate the instance and see if it comes unstuck. If this solves it again, I'll get work on the backlog to automate instance rotation on a regular basis.

@pbrisbin
Copy link
Member

pbrisbin commented May 22, 2023

Instance rotation occurred between 15:00-15:15ET. Please let me know if have a builds run on the same changed files after that time, and if they succeed now or 137 again.

@bzbarsky-apple
Copy link
Author

Will do!

@bzbarsky-apple
Copy link
Author

I am seeing things like https://restyled.io/gh/project-chip/repos/connectedhomeip/jobs/3215477 but that seems like a different issue, with a much clearer error message.

@pbrisbin
Copy link
Member

That is the same issue, but I improved the error message the other day. This does mean that rotating the underlying instance did not help, so it's possible you have an actual case where google-java-format is using more memory that we're willing to allocate.

@bzbarsky-apple
Copy link
Author

That is entirely possible, because the java files involved are ... very large. OK, thanks! We will need to figure out what to do with that.

There's no way we can configure the memory allocated via the configuration YAML, right?

@pbrisbin
Copy link
Member

pbrisbin commented May 26, 2023

There's no way we can configure the memory allocated via the configuration YAML, right?

Unfortunately not, this constraint is sort of a security/reliability/cost thing. We don't want to give folks a knob that can let them turn themselves into a noisy-neighbor problem. This is the sort of thing that I could offer some day as a paid feature (it's no different than paying for bigger job-runners on CI), but I just haven't built anything to do that logistically yet. If that's something you'd be interested, I'd love to talk more about it.

Hopefully some of the suggestions in that help doc can work for you though!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants