Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Question - How to interact with sites that support oly TLS 1.2 #1080

Closed
Korporal opened this issue Feb 9, 2018 · 6 comments
Closed

Question - How to interact with sites that support oly TLS 1.2 #1080

Korporal opened this issue Feb 9, 2018 · 6 comments

Comments

@Korporal
Copy link

Korporal commented Feb 9, 2018

We have code that interacts with Vendors using REST, most of these systems use RestSharp. Yesterday we got hit by failures (nothing to do with RestSharp) which are detailed here:

octokit/octokit.net#1756

As you can see Github temporarily set their site to no longer support TLS 1.0 and things failed.

My question is that we are interacting with other sites that we know will upgrade to TLS 1.2 in March and we have no idea if we must update RestSharp or adjust our code to somehow tell RestSharp to use TLS 1.2.

Can anyone shed light on this?

@alexeyzimarev
Copy link
Member

Please do not ignore contribution guidelines and ask questions on StackOverflow

@Korporal
Copy link
Author

Korporal commented Feb 9, 2018

Hi Alexey,

I'm sorry but I'm not able to use StackOverflow because they prohibit users from asking questions if their previous questions are not deemed "interesting" the site is useless and not well regarded and as I say is not an option for me.

Can you at least summarize what TLS support or options exist within RestSharp?

Thank you.

@Korporal
Copy link
Author

Korporal commented Feb 9, 2018

@alexeyzimarev - Hi,

Was it really necessary to close this so soon? Perhaps others out there might have something to contribute?

@Lechus
Copy link

Lechus commented Feb 12, 2018

@Korporal : just use Google: How to enable TLS 1.2 on my pc... It is RestSharp independant.
Resolution: https://blogs.perficient.com/microsoft/2016/04/tsl-1-2-and-net-support/

PS. There is already answer. No needed to create a new issue. #1075

@hgleaves-ncuadmin
Copy link

@Lechus - How am I to know that RestSharp provides no way of setting this unless I ask first? I have "googled" the subject and I have already found and read these articles. I simply wanted to know if RestSharp did or did not handle this, for all I know RestSharp may explicitly set the protocol to support 1.2 or it may provide some option for doing so, that's why I asked the question.

Thanks

@alexeyzimarev
Copy link
Member

RestSharp is not reinventing the week (well, it does to some extent but still) and uses HttpWebRequest. .NET 4.6 has TLS 1.2 enabled by default.

NET 4.6 and above. You don’t need to do any additional work to support TLS 1.2, it’s supported by default.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants