Skip to content
This repository has been archived by the owner on Nov 4, 2023. It is now read-only.

feat: allow custom classes on screensaver slides #796

Merged
merged 3 commits into from
Dec 4, 2021
Merged

feat: allow custom classes on screensaver slides #796

merged 3 commits into from
Dec 4, 2021

Conversation

mrsbh
Copy link
Contributor

@mrsbh mrsbh commented Nov 25, 2021

No description provided.

@rchl
Copy link
Collaborator

rchl commented Nov 26, 2021

Should be also mentioned in the readme. Otherwise it's a feature that nobody will know about.

@mrsbh
Copy link
Contributor Author

mrsbh commented Nov 27, 2021

Should be also mentioned in the readme. Otherwise it's a feature that nobody will know about.

I was thinking of updating https://github.com/resoai/TileBoard/wiki/Screensaver-configuration rather than updating the README.md. README has lesser of screensaver details than the wiki page. If I update the README with just this feature, then that would be off.

I am assuming I would have the permission to edit https://github.com/resoai/TileBoard/wiki/Screensaver-configuration

@rchl
Copy link
Collaborator

rchl commented Nov 27, 2021

Yes, readme should regardless list all supported options, even if it does not go into details.

@mrsbh
Copy link
Contributor Author

mrsbh commented Dec 3, 2021

@rchl I have added documentation for the feature to README. Can this be merged now ?

@rchl rchl changed the title Allow classes on screensaver slides feat: allow custom classes on screensaver slides Dec 4, 2021
@rchl rchl merged commit 514abba into resoai:master Dec 4, 2021
@mrsbh mrsbh deleted the screensaver_slide_classes branch December 17, 2021 23:33
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mrsbh @rchl