Skip to content
This repository has been archived by the owner on Nov 4, 2023. It is now read-only.

fix: camera title extending beyong tile boundaries #449

Merged
merged 1 commit into from
Oct 1, 2020
Merged

fix: camera title extending beyong tile boundaries #449

merged 1 commit into from
Oct 1, 2020

Conversation

akloeckner
Copy link
Contributor

fixes #429

rchl
rchl reviewed Oct 1, 2020
View reviewed changes
styles/main.less
@@ -649,6 +649,7 @@ body {
text-shadow: 1px 1px 0 rgba(0,0,0,.2);
background: rgba(0,0,0,0.15);
right: auto;
max-width: calc(100% - 6px - 12px);
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you can instead just set right: 3px.

If that works then that's preferred since calc is a fairly new feature so should be used sparingly in this project that aims to be compatible with some old crap devices.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, sorry, that would not be equivalent when text is shorter than width.

Would be easy to fix with plain css by adding an extra wrapper element but I won't require that here.

@rchl rchl merged commit bd6c37d into resoai:master Oct 1, 2020
@rchl rchl added the hacktoberfest-accepted Accept for Hacktoberfest label Oct 6, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@rchl rchl rchl approved these changes

Assignees
No one assigned
Labels
hacktoberfest-accepted Accept for Hacktoberfest
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Title outgrowing tile for camera
2 participants
@akloeckner @rchl