Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release plugin continues to execute after preTagCommit command fails #128

Closed
grigorigoldman opened this issue Aug 30, 2015 · 1 comment
Closed
Milestone

Comments

@grigorigoldman
Copy link

We've noticed that when running gradle release command and it fails when executing the preTagCommit task:

28-Aug-2015 15:36:57    Running [git, commit, -a, -m, [Gradle Release Plugin] - pre tag commit:  '1.0.10'.] produced an error: [*** Please tell me who you are.
28-Aug-2015 15:36:57    
28-Aug-2015 15:36:57    Run
28-Aug-2015 15:36:57    
28-Aug-2015 15:36:57      git config --global user.email "[email protected]"
28-Aug-2015 15:36:57      git config --global user.name "Your Name"
28-Aug-2015 15:36:57    
28-Aug-2015 15:36:57    to set your account's default identity.
28-Aug-2015 15:36:57    Omit --global to set the identity only in this repository.
28-Aug-2015 15:36:57    
28-Aug-2015 15:36:57    fatal: unable to auto-detect email address (got 'xxx@yyy.(none)')]

The problem is, the job Bamboo job continues to run, which causes issues because we publish our artefact to Nexus but then subsequently fail to up the version (for the same reason). We then can't rerun the failed job because we're set restrictions on Nexus to disallow artefact overwrites. Looking at the Executor.exec method (line 50), it should be catching this and throw exception but it doesn't seem to be happening.

@danez danez closed this as completed in 51bf677 Sep 1, 2015
@danez
Copy link
Contributor

danez commented Sep 1, 2015

Thanks, should be fixed in next release

@danez danez added this to the 2.2.2 milestone Sep 1, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants