fix: throw exception on invalid input to setExtraCaptureElement

researchgate · Nov 17, 2016 · 49081ec · 49081ec
1 parent 023bd6f
commit 49081ec
Show file tree

Hide file tree

Showing 2 changed files with 24 additions and 3 deletions.
diff --git a/lib/server-suite-wrapper.js b/lib/server-suite-wrapper.js
@@ -1,5 +1,6 @@
 'use strict';
 const RENDER_TARGET_SELECTOR = '[data-gemini-react] > *';
+const _ = require('lodash');
 class ServerSuiteWrapper {
     /**
      * @param {Suite} suite
@@ -45,9 +46,10 @@ class ServerSuiteWrapper {
     }
 
     setExtraCaptureElements(elements) {
-        if (elements && elements.length) {
-            this._captureElements = this._captureElements.concat(elements);
+        if (!Array.isArray(elements) && !_.isString(elements)) {
+            throw new Error('setExtraCaptureElements accepts an array or string');
         }
+        this._captureElements = this._captureElements.concat(elements);
         return this;
     }
 }

diff --git a/test/server-suite-wrapper.js b/test/server-suite-wrapper.js
@@ -109,14 +109,33 @@ describe('server-suite-wrapper', () => {
         });
 
         describe('setExtraCaptureElements', () => {
-            it('should capture additional selectors', () => {
+            it('should work with a string', () => {
                 const selector = '.extra-selector';
 
                 wrapped.setExtraCaptureElements(selector);
                 wrapped.render();
 
                 assert.calledWithExactly(original.setCaptureElements, [RENDER_TARGET_SELECTOR, selector]);
             });
+
+            it('should work with an array', () => {
+                const selector1 = '.selector1';
+                const selector2 = '.selector2';
+
+                wrapped.setExtraCaptureElements([selector1, selector2]);
+                wrapped.render();
+
+                assert.calledWithExactly(
+                    original.setCaptureElements,
+                    [RENDER_TARGET_SELECTOR, selector1, selector2]
+                );
+            });
+
+            it('should throw on non array and non string argument', () => {
+                assert.throws(() => {
+                    wrapped.setExtraCaptureElements(1234);
+                }, 'setExtraCaptureElements accepts an array or string');
+            });
         });
     });
 });