-
Notifications
You must be signed in to change notification settings - Fork 455
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix trailing undefined for optional parameters not omitted with @send #6716
Fix trailing undefined for optional parameters not omitted with @send #6716
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice find! I wonder if there are more code paths where it should be applied...
@zth I now moved the handling directly to Not sure what the cases |
Also, I was wondering: External function calls with trailing undefineds will probably be the exception rather than the rule, but we are now doing additional list allocations whenever we emit code for any external function call - should we maybe first check if there are any trailing undefineds before doing these list computations? |
I'll let @cristianoc have a final look at this too, looks good from my side. |
Added check |
Fixes #6715