Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Variants for entity fields #7417

Open
aecins opened this issue Sep 13, 2024 · 3 comments
Open

Variants for entity fields #7417

aecins opened this issue Sep 13, 2024 · 3 comments
Labels
enhancement New feature or request 📺 re_viewer affects re_viewer itself

Comments

@aecins
Copy link

aecins commented Sep 13, 2024

Is your feature request related to a problem? Please describe.
I would like to be able to visualize a pointcloud in ReRun with different colorization options. For example we may want to colorize a pointcloud based on DISTANCE_FROM_SENSOR, SURFACE_NORMAL_ORIENTATION, SEMSEG_CLASS. ReRun viewer GUI should allow switching between the different colorization options. This feature would make ReRun a more powerful tool for visualizing 3D reconstruction results or debugging robotics 3D perception outputs.

Describe the solution you'd like
A possible solution is to allow entities to have variants for its fields. For the example above, a Points3D entity could have multiple variants for the colors field. The blueprint is then responsible for deciding which one of the variants is currently visualized.

Describe alternatives you've considered
The desired behavior can be "approximated" with the current build by logging multiple Point3D entities with identical point positions but different point colors. However, this approach has the following downsides:

  1. it wastes memory space by logging duplicated point position data
  2. it creates multiple separate entities for the same pointcloud. This means that changing the colorization mode requires at least two toggle switches: one to turn off current colorization and one to turn on the desired colorization. Also, it is not clear what the behavior of the visualizer should be if multiple pointcloud entities with the same point positions are visible at the same time.

Additional context

@aecins aecins added enhancement New feature or request 👀 needs triage This issue needs to be triaged by the Rerun team labels Sep 13, 2024
@jpazhaya
Copy link

Colorizing options within the visualizer would be great too. i.e. just like how rviz enables coloring point clouds by selecting channel and color scales.

@emilk emilk added 📺 re_viewer affects re_viewer itself and removed 👀 needs triage This issue needs to be triaged by the Rerun team labels Sep 18, 2024
@Wumpf
Copy link
Member

Wumpf commented Sep 18, 2024

@jpazhaya btw. there's already some limited edit options for colors and other things in the viewer via the override panel when you select an entity :)
I imagine predefined color sets could be part of this ask for sets (predefined ones included?) to choose from!

See also

... and I'm pretty sure there was something about "color derived from other values" (like velocity) but can't find it right now 🤔

@teh-cmc
Copy link
Member

teh-cmc commented Sep 23, 2024

That's also very much in line with tagged components: one could log a bunch of Color components with user-defined tags, then switch the tag in use at runtime using the UI and/or blueprint APIs (i.e. visualizer overrides).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request 📺 re_viewer affects re_viewer itself
Projects
None yet
Development

No branches or pull requests

5 participants