Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Transform3D should have an affine3d= helper. #3645

Closed
jleibs opened this issue Oct 4, 2023 · 4 comments
Closed

Transform3D should have an affine3d= helper. #3645

jleibs opened this issue Oct 4, 2023 · 4 comments
Labels
🐑🐑 duplicate This issue or pull request already exists enhancement New feature or request 🐍 Python API Python logging API

Comments

@jleibs
Copy link
Member

jleibs commented Oct 4, 2023

A 3x4 affine matrix is a common representation. Would be nice to be able to pass this directly to rr.Transform3D instead of needing to:

rr.Transform3D(translation=transform[:,3], mat3x3=transform[:,0:3])
@jleibs jleibs added enhancement New feature or request 🐍 Python API Python logging API labels Oct 4, 2023
@Wumpf
Copy link
Member

Wumpf commented Oct 5, 2023

@emilk
Copy link
Member

emilk commented Oct 9, 2023

If we call the parameter affine3d I think it should accept both a 3x4 and a 4x4 matrix, and in the latter case just ignore the last row

(or is it 4x3? or is it ignore the last column?)

@Wumpf
Copy link
Member

Wumpf commented Oct 24, 2023

I believe we're now in a good spot to just support 3x4 and 4x4 directly as new union variants. I'd prefer we solve it like that for all languages instead of doing a python specific thing (beyond special named parameters)

@Wumpf Wumpf added this to the 0.11 C++ polish milestone Oct 24, 2023
@emilk emilk removed this from the 0.11 milestone Nov 21, 2023
@Wumpf
Copy link
Member

Wumpf commented Jul 31, 2024

closing this as won't do / duplicate:
we do have to add a matrix 4x4 and matrix 3x4, but the way we're modelling data right now (and potentially in the future) a affine3d= helper doesn't make sense because it implies introducing an Affine3D

For additional matrices see:

@Wumpf Wumpf closed this as not planned Won't fix, can't repro, duplicate, stale Jul 31, 2024
@Wumpf Wumpf added the 🐑🐑 duplicate This issue or pull request already exists label Jul 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐑🐑 duplicate This issue or pull request already exists enhancement New feature or request 🐍 Python API Python logging API
Projects
None yet
Development

No branches or pull requests

3 participants