Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

entity: configure the editor #3300

Merged
merged 1 commit into from
Apr 6, 2023
Merged

entity: configure the editor #3300

merged 1 commit into from
Apr 6, 2023

Conversation

jma
Copy link
Contributor

@jma jma commented Apr 4, 2023 •
edited
Loading

  • Configures the entity type select in the editor.
  • Uses only one identifier definition.
  • Fixes oneOf configurations.
  • Fixes editor UI layout.
  • Fixes $ref resolution in during the document importation.
  • Uses the dump method in the serializer when the resolve=1.
  • Fixes aggregations size configuration.
  • Fixes query boosting.
  • Fixes autocomplete max length.

Co-authored-by: Johnny Mariéthoz [email protected]

Dependencies

@github-actions github-actions bot added dev: DB Database structure (models.py) dev: fixtures Fixtures data used for ils.test and ilsdev.test developers From a developer point of view. f: circulation Concerns the circulation interface or backend f: data About data model, importation, transformation, exportation of data, specific for bibliographic data f: data migration Data migration from a legacy system or a previous version f: notifications f: permissions Concerns the rights management f: search f: user management labels Apr 4, 2023
@jma jma force-pushed the maj-fix-entity branch 4 times, most recently from 3fd00b6 to 1cb9d36 Compare April 5, 2023 07:31
@jma jma changed the title Maj fix entity entity: configure the editor Apr 5, 2023
@jma jma marked this pull request as ready for review April 5, 2023 07:36
@jma jma force-pushed the maj-fix-entity branch from 1cb9d36 to 39aecf5 Compare April 5, 2023 07:44
Garfield-fr
Garfield-fr approved these changes Apr 5, 2023
View reviewed changes
rero_ils/modules/documents/jsonschemas/documents/document_contribution_organisation-v0.0.1.json Outdated
@@ -46,6 +46,8 @@
"subordinate_unit": {
"title": "Subordinate units",
"type": "array",
"minItems": 1,
"maxItems": 2,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To be deleted?

rero_ils/modules/documents/jsonschemas/documents/document_entity_link-v0.0.1.json Outdated
},
"templateOptions": {
"requiredExpression": "true",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Necessary?

rero_ils/modules/documents/jsonschemas/documents/document_entity_local-v0.0.1.json Outdated
@@ -79,7 +80,8 @@
"minLength": 3,
"form": {
"templateOptions": {
"itemCssClass": "col-lg-6"
"itemCssClass": "col-lg-6",
"hide": true
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Necessary?

@jma
entity: configure the editor
8152194 
- Configures the entity type select in the editor.
- Uses only one identifier definition.
- Fixes oneOf configurations.
- Fixes editor UI layout.
- Fixes $ref resolution in during the document importation.
- Uses the dump method in the serializer when the resolve=1.
- Fixes aggregations size configuration.
- Fixes query boosting.
- Fixes autocomplete max length.
- Closes rero#2619.

Co-authored-by: Johnny Mariéthoz <[email protected]>
@jma jma force-pushed the maj-fix-entity branch from 39aecf5 to 8152194 Compare April 6, 2023 06:08
@jma jma merged commit 9808182 into rero:US-2434-entity Apr 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Garfield-fr Garfield-fr Garfield-fr approved these changes

@zannkukai zannkukai zannkukai approved these changes

@rerowep rerowep Awaiting requested review from rerowep

@lauren-d lauren-d Awaiting requested review from lauren-d

Assignees
No one assigned
Labels
dev: DB Database structure (models.py) dev: fixtures Fixtures data used for ils.test and ilsdev.test developers From a developer point of view. f: circulation Concerns the circulation interface or backend f: data migration Data migration from a legacy system or a previous version f: data About data model, importation, transformation, exportation of data, specific for bibliographic data f: notifications f: permissions Concerns the rights management f: search f: user management
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jma @Garfield-fr @zannkukai