Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

permissions: fix patron read permission #3281

Merged
merged 1 commit into from
Mar 14, 2023
Merged

permissions: fix patron read permission #3281

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 6 additions & 5 deletions rero_ils/modules/permissions.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -430,12 +430,13 @@ def needs(self, record=None, *args, **kwargs):
if record:
if self.record_mapper:
record = self.record_mapper(record)
required_need = None
required_need = set()
if current_patrons:
required_need = OwnerNeed(self.patron_callback(record))
elif current_librarian:
required_need = OrganisationNeed(record.organisation_pid)
if required_need and required_need not in g.identity.provides:
required_need.add(OwnerNeed(self.patron_callback(record)))
if current_librarian:
required_need.add(OrganisationNeed(record.organisation_pid))
if required_need and not required_need.intersection(
g.identity.provides):
return []

return super().needs(record, **kwargs)
Expand Down
28 changes: 28 additions & 0 deletions tests/api/patrons/test_patrons_permissions.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -142,3 +142,31 @@ def test_patrons_permissions(
librarian_martigny['roles'] = original_roles
librarian_martigny.update(librarian_martigny, dbcommit=True, reindex=True)
flush_index(PatronsSearch.Meta.index)

original_roles = patron_martigny.get('roles', [])

# librarian + patron roles
patron_martigny['roles'] = [UserRole.FULL_PERMISSIONS, UserRole.PATRON]
patron_martigny['libraries'] = librarian_martigny['libraries']
patron_martigny.update(patron_martigny, dbcommit=True, reindex=True)
flush_index(PatronsSearch.Meta.index)

login_user(patron_martigny.user) # to refresh identity !
check_permission(PatronPermissionPolicy, {'search': True}, {})
check_permission(PatronPermissionPolicy, {
'read': True,
'create': True,
'update': True,
'delete': True
}, patron_martigny)
check_permission(PatronPermissionPolicy, {
'read': True,
'create': True,
'update': True,
'delete': True
}, patron2_martigny)

patron_martigny['roles'] = original_roles
del patron_martigny['libraries']
patron_martigny.update(patron_martigny, dbcommit=True, reindex=True)
flush_index(PatronsSearch.Meta.index)