Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move test server alert to app header #2966

Merged
merged 1 commit into from
Jun 23, 2022
Merged

Move test server alert to app header #2966

merged 1 commit into from
Jun 23, 2022

Conversation

PascalRepond
Copy link
Contributor

Co-Authored-by: Pascal Repond [email protected]

Why are you opening this PR?

  • The test server alert message is moved just under the navbar in the header template so that it is displayed across the app.
  • On test deployments (including bib.test), use config RERO_ILS_STATE_PRODUCTION = False to show the alert

@PascalRepond PascalRepond requested a review from pronguen June 22, 2022 10:40
@PascalRepond PascalRepond merged commit 51fd030 into rero:staging Jun 23, 2022
@PascalRepond PascalRepond deleted the rep-testmsg branch June 23, 2022 06:36
@PascalRepond PascalRepond added the enhancement Improvement of an existing feature label Jun 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Garfield-fr Garfield-fr Garfield-fr approved these changes

@zannkukai zannkukai zannkukai approved these changes

@rerowep rerowep Awaiting requested review from rerowep

@jma jma Awaiting requested review from jma

@pronguen pronguen Awaiting requested review from pronguen

Assignees
No one assigned
Labels
enhancement Improvement of an existing feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@PascalRepond @Garfield-fr @zannkukai