Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make isort consistent for Travis and local development #816

Closed
blankoworld opened this issue Feb 28, 2020 · 0 comments
Closed

Make isort consistent for Travis and local development #816

blankoworld opened this issue Feb 28, 2020 · 0 comments
Labels
developers From a developer point of view.

Comments

@blankoworld
Copy link
Contributor

Describe the issue

b8fc567 shows that Travis don't find these isort problems.

As the ticket PyCQA/isort#1147 explains, next isort version will fix this problem.

I make a configuration for isort here: blankoworld@e8bc788

To Reproduce

  1. Use commit before b8fc567
  2. Launch pipenv run isort -rc -c -df
  3. It should give you 2 files with a problem
  4. Push your branch on Travis
  5. Travis don't show any problem

Expected behavior
Travis should show these problems.
@blankoworld blankoworld added the developers From a developer point of view. label Feb 28, 2020
@rerowep rerowep closed this as completed Sep 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
developers From a developer point of view.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@blankoworld @rerowep