New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OAuth: user without patron returns error #3607

Closed

PascalRepond opened this issue Feb 22, 2024 · 0 comments

Assignees

Labels

bug dev: monitoring

Contributor

PascalRepond commented Feb 22, 2024

Bug description:

When calling the patrons API for OAuth (example: https://bib.rero.ch/api/patrons/info?access_token=xxxxxxx), if the user linked to the access token has no patron, there is an error (see Sentry: RERO-ILS-530).

Expected behavior:

When such a call is made, a more telling error should be returned, for example : "This user is not linked to an institution and can therefore not be authorized."

PascalRepond added the bug label

github-project-automation bot added this to RERO ILS issues

github-project-automation bot moved this to Inbox in RERO ILS issues

PascalRepond added the dev: monitoring label

PascalRepond moved this from Inbox to Product Backlog in RERO ILS issues

rerowep added a commit to rerowep/rero-ils that referenced this issue


          patron: fix API /info

985c6d3

* Fixes API /info for users without patron.
* Closes: rero#3607.

Co-Authored-by: Peter Weber <[email protected]>

Garfield-fr assigned rerowep

Garfield-fr moved this from Product Backlog to In Development in RERO ILS issues

rerowep moved this from In Development to Ready to test in RERO ILS issues

rerowep added a commit to rerowep/rero-ils that referenced this issue


          patron: fix API /info

f0824d5

* Fixes API /info for users without patron.
* Closes: rero#3607.

Co-Authored-by: Peter Weber <[email protected]>

rerowep closed this as completed in

acf40ef

github-project-automation bot moved this from Ready to test to Done in RERO ILS issues

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment