Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Circulation: item in transit can wrongfully become at_desk #3403

Closed
PascalRepond opened this issue Jul 12, 2023 · 0 comments · Fixed by #3579
Closed

Circulation: item in transit can wrongfully become at_desk #3403

PascalRepond opened this issue Jul 12, 2023 · 0 comments · Fixed by #3579
Labels
bug Breaks something but is not blocking client request Issue reported by production libraries f: circulation Concerns the circulation interface or backend

Comments

@PascalRepond
Copy link
Contributor

PascalRepond commented Jul 12, 2023 •
edited
Loading

Bug description:

In a certain specific case, an item that is in transit and with another pending request can become directly at_desk and sends an availability notification when the first request is cancelled. This seems to happen only if the transaction library of both requests is the same.

Linked to an incomplete fixing of issue #2454
May be linked to #3569

Expected behavior:

Cancelling a request when the status of the item is in_transit_for_pickup or in_transit_to_house should never become at_desk or send an availability notification. In this case, the item should stay in_transit_for_pickup and the notification should only be generated when the item is recieved.

Steps to Reproduce:

  1. (Log in with syslib)
  2. With active library A, request an item from library B to pickup in library A for patron1
  3. With active library B, validate the request.
  4. With active library A, request the same item to pickup in library A for patron2
  5. With active library A, cancel the first request.
  6. See that a notification is generated for patron2 and the item status becomes at_desk when it should still be in_transit_for_pickup because it has not been recieved by library A yet.

Version:

v1.17.0

Screenshots

tempsnip
@PascalRepond PascalRepond added f: circulation Concerns the circulation interface or backend bug Breaks something but is not blocking labels Jul 12, 2023
@PascalRepond PascalRepond added the client request Issue reported by production libraries label Jul 12, 2023
@PascalRepond PascalRepond changed the title Circulation: item in transit wrongfully becoming at_desk Circulation: item in transit can wrongfully become at_desk Jul 12, 2023
@PascalRepond PascalRepond moved this from Inbox to Product Backlog in RERO ILS issues Jul 24, 2023
@PascalRepond PascalRepond moved this from Product Backlog to Sprint backlog in RERO ILS issues Dec 20, 2023
@PascalRepond PascalRepond moved this from Sprint backlog to Product Backlog in RERO ILS issues Dec 20, 2023
PascalRepond added a commit to PascalRepond/rero-ils that referenced this issue Jan 16, 2024
@PascalRepond
fix(circ): item can wrongfully become at desk
d4a8eff 
* Closes rero#3403.

Co-Authored-by: Pascal Repond <[email protected]>
PascalRepond added a commit to PascalRepond/rero-ils that referenced this issue Jan 16, 2024
@PascalRepond
fix(circ): item can wrongfully become at desk
72efd20 
* Fixes incorrect test for action CANCEL_REQUEST_5_1_2.
* Closes rero#3403.

Co-Authored-by: Pascal Repond <[email protected]>
@PascalRepond PascalRepond mentioned this issue Jan 16, 2024
Merged
@PascalRepond PascalRepond moved this from Product Backlog to In Development in RERO ILS issues Jan 16, 2024
PascalRepond added a commit to PascalRepond/rero-ils that referenced this issue Jan 16, 2024
@PascalRepond
fix(circ): item can wrongfully become at desk
a98ff93 
* Fixes incorrect test for action CANCEL_REQUEST_5_1_2.
* Closes rero#3403.

Co-Authored-by: Pascal Repond <[email protected]>
PascalRepond added a commit to PascalRepond/rero-ils that referenced this issue Jan 17, 2024
@PascalRepond
fix(circ): item can wrongfully become at desk
e81e418 
* Fixes incorrect test for action CANCEL_REQUEST_5_1_2.
* Closes rero#3403.

Co-Authored-by: Pascal Repond <[email protected]>
PascalRepond added a commit to PascalRepond/rero-ils that referenced this issue Jan 18, 2024
@PascalRepond
fix(circ): item can wrongfully become at desk
bcd79cb 
* Fixes incorrect test for action CANCEL_REQUEST_5_1_2.
* Closes rero#3403.
* Closes rero#3569.

Co-Authored-by: Pascal Repond <[email protected]>
PascalRepond added a commit to PascalRepond/rero-ils that referenced this issue Jan 18, 2024
@PascalRepond
fix(circ): item can wrongfully become at desk
41985fd 
* Fixes incorrect test for action CANCEL_REQUEST_5_1_2.
* Closes rero#3403.
* Closes rero#3569.

Co-Authored-by: Pascal Repond <[email protected]>
PascalRepond added a commit to PascalRepond/rero-ils that referenced this issue Jan 18, 2024
@PascalRepond
fix(circ): item can wrongfully become at desk
852ad17 
* Fixes incorrect test for action CANCEL_REQUEST_5_1_2.
* Closes rero#3403.
* Closes rero#3569.

Co-Authored-by: Pascal Repond <[email protected]>
PascalRepond added a commit to PascalRepond/rero-ils that referenced this issue Jan 19, 2024
@PascalRepond
fix(circ): item can wrongfully become at desk
360db7b 
* Fixes incorrect test for action CANCEL_REQUEST_5_1_2.
* Closes rero#3403.
* Closes rero#3569.

Co-Authored-by: Pascal Repond <[email protected]>
PascalRepond added a commit that referenced this issue Jan 22, 2024
@PascalRepond
fix(circ): item can wrongfully become at desk
db30f23 
* Fixes incorrect test for action CANCEL_REQUEST_5_1_2.
* Closes #3403.
* Closes #3569.

Co-Authored-by: Pascal Repond <[email protected]>
@PascalRepond PascalRepond moved this from In Development to In testing in RERO ILS issues Jan 22, 2024
PascalRepond added a commit that referenced this issue Jan 24, 2024
@PascalRepond
fix(circ): item can wrongfully become at desk
4c8c540 
* Fixes incorrect test for action CANCEL_REQUEST_5_1_2.
* Closes #3403.
* Closes #3569.

Co-Authored-by: Pascal Repond <[email protected]>
@github-project-automation github-project-automation bot moved this from In testing to Done in RERO ILS issues Jan 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Breaks something but is not blocking client request Issue reported by production libraries f: circulation Concerns the circulation interface or backend
Projects
RERO ILS issues
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(circ): item can wrongfully become at desk PascalRepond/rero-ils
1 participant
@PascalRepond