Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

users: library used for the operation logs is wrong #3310

Closed
PascalRepond opened this issue Apr 13, 2023 · 1 comment · Fixed by #3372
Closed

users: library used for the operation logs is wrong #3310

PascalRepond opened this issue Apr 13, 2023 · 1 comment · Fixed by #3372
Assignees
@Garfield-fr
Labels
correction An implemented feature doesn't work as expected. f: user management

Comments

@PascalRepond
Copy link
Contributor

PascalRepond commented Apr 13, 2023 •
edited
Loading

How it works

Currently, patron.libraries contains all libraries where the user has rights, in an unordered list. This causes problems for librarians with multiple libraries since when we need a user's library in some data, we use the first of the list.

Improvement suggestion

  • Find a way to use the current active library (from the UI switch-library menu) everywhere we need a professional user's library to inject in operation logs:
    • document
    • item
    • holding
    • Other? To be specified
@PascalRepond PascalRepond added f: user management correction An implemented feature doesn't work as expected. labels Apr 13, 2023
@PascalRepond PascalRepond moved this from Inbox to Product Backlog in RERO ILS issues Apr 13, 2023
@PascalRepond PascalRepond mentioned this issue Apr 14, 2023
Merged
@PascalRepond PascalRepond moved this from Product Backlog to Sprint backlog in RERO ILS issues Apr 18, 2023
@PascalRepond PascalRepond moved this from Sprint backlog to Product Backlog in RERO ILS issues Apr 24, 2023
@PascalRepond PascalRepond moved this from Product Backlog to Ready to test in RERO ILS issues May 3, 2023
@PascalRepond PascalRepond moved this from Ready to test to Inbox in RERO ILS issues May 3, 2023
@PascalRepond
Copy link
Contributor Author

Planning 03.05.23, dev remark: We should use the cache or the session to store this information rather than the backend.

@PascalRepond PascalRepond moved this from Inbox to Product Backlog in RERO ILS issues May 15, 2023
@PascalRepond PascalRepond changed the title users: add a way to set a main library users: library used for the operation logs is wrong May 15, 2023
@Garfield-fr Garfield-fr moved this from Product Backlog to In Development in RERO ILS issues Jun 13, 2023
@Garfield-fr Garfield-fr self-assigned this Jun 13, 2023
Garfield-fr added a commit to Garfield-fr/rero-ils that referenced this issue Jun 13, 2023
@Garfield-fr
operation logs: assign current library request
ed31388 
When the current_library parameter is present in the request,
it is assigned to the library in the logs operation.

* Closes rero#3310.

Co-Authored-by: Bertrand Zuchuat <[email protected]>
@Garfield-fr Garfield-fr mentioned this issue Jun 13, 2023
Merged
Garfield-fr added a commit to Garfield-fr/rero-ils that referenced this issue Jun 13, 2023
@Garfield-fr
operation logs: assign current library request
30156c1 
When the current_library parameter is present in the request,
it is assigned to the library in the logs operation.

* Closes rero#3310.

Co-Authored-by: Bertrand Zuchuat <[email protected]>
Garfield-fr added a commit to Garfield-fr/rero-ils that referenced this issue Jun 13, 2023
@Garfield-fr
operation logs: assign current library request
242f6a3 
When the current_library parameter is present in the request,
it is assigned to the library in the logs operation.

* Closes rero#3310.

Co-Authored-by: Bertrand Zuchuat <[email protected]>
Garfield-fr added a commit to Garfield-fr/rero-ils that referenced this issue Jun 13, 2023
@Garfield-fr
operation logs: assign current library request
f408535 
When the current_library parameter is present in the request,
it is assigned to the library in the logs operation.

* Closes rero#3310.

Co-Authored-by: Bertrand Zuchuat <[email protected]>
@Garfield-fr Garfield-fr moved this from In Development to Ready to test in RERO ILS issues Jun 15, 2023
Garfield-fr added a commit to Garfield-fr/rero-ils that referenced this issue Jun 19, 2023
@Garfield-fr
operation logs: assign current library request
dd2c043 
When the current_library parameter is present in the request,
it is assigned to the library in the logs operation.

* Closes rero#3310.

Co-Authored-by: Bertrand Zuchuat <[email protected]>
Garfield-fr added a commit to Garfield-fr/rero-ils that referenced this issue Jun 19, 2023
@Garfield-fr
operation logs: assign current library request
4e54a1e 
When the current_library parameter is present in the request,
it is assigned to the library in the logs operation.

* Closes rero#3310.

Co-Authored-by: Bertrand Zuchuat <[email protected]>
PascalRepond pushed a commit that referenced this issue Jun 19, 2023
@Garfield-fr @PascalRepond
operation logs: assign current library request
0c062a8 
When the current_library parameter is present in the request,
it is assigned to the library in the logs operation.

* Closes #3310.

Co-Authored-by: Bertrand Zuchuat <[email protected]>
@PascalRepond PascalRepond moved this from Ready to test to In testing in RERO ILS issues Jun 19, 2023
@PascalRepond PascalRepond moved this from In testing to Approved in RERO ILS issues Jun 20, 2023
@github-project-automation github-project-automation bot moved this from Approved to Done in RERO ILS issues Jun 21, 2023
Garfield-fr added a commit that referenced this issue Jun 21, 2023
@Garfield-fr
operation logs: assign current library request
c7091d2 
When the current_library parameter is present in the request,
it is assigned to the library in the logs operation.

* Closes #3310.

Co-Authored-by: Bertrand Zuchuat <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Garfield-fr Garfield-fr

Labels
correction An implemented feature doesn't work as expected. f: user management
Projects
RERO ILS issues
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

operation logs: assign current library request Garfield-fr/rero-ils
2 participants
@Garfield-fr @PascalRepond