Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Syntax error in stale.yml GitHub Workflow #3217

Closed
bertvandepoel opened this issue Jan 18, 2023 · 1 comment · Fixed by #3218
Closed

Syntax error in stale.yml GitHub Workflow #3217

bertvandepoel opened this issue Jan 18, 2023 · 1 comment · Fixed by #3218
Labels
correction An implemented feature doesn't work as expected. developers From a developer point of view.

Comments

@bertvandepoel
Copy link

I was talking to a friend about how I have to check up on an issue here from time to time or it gets closed by the GitHub Actions bot. He thought this was weird, so he looked at https://github.com/rero/rero-ils/blob/staging/.github/workflows/stale.yml and remarked that there's a mistake in this file. The comment on https://github.com/rero/rero-ils/blob/staging/.github/workflows/stale.yml#L16 seems to imply the intention is to not close but just to mark stale issues. However, 0 is not the correct value for "days-before-close:". The correct value is false. Therefore, after 180 days, the bot marks the issue as stale and immediately also closes it. This is not intended behaviour, so stale.yml should be edited to fix the syntax error, either with true if the current behaviour is desired or, in my opinion ideally, false to reflect the intention of the comment and to prevent relevant bugs waiting for someone to fix them from being closed.

@bertvandepoel bertvandepoel added the correction An implemented feature doesn't work as expected. label Jan 18, 2023
@PascalRepond PascalRepond added the developers From a developer point of view. label Jan 19, 2023
PascalRepond added a commit to PascalRepond/rero-ils that referenced this issue Jan 19, 2023
@PascalRepond
Copy link
Contributor

Hi and thanks for your issue.

You are correct in that the comment in the file does not correspond to the actual behaviour. Rest assured that the project team is notified when an issue is closed and always reopened it if the issue was still relevant. We will nonetheless fix this behaviour to prevent automatic closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
correction An implemented feature doesn't work as expected. developers From a developer point of view.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants