Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Strings i18nPlural seem to not be translated correctly #3112

Closed
PascalRepond opened this issue Sep 27, 2022 · 0 comments · Fixed by rero/rero-ils-ui#951
Closed

Strings i18nPlural seem to not be translated correctly #3112

PascalRepond opened this issue Sep 27, 2022 · 0 comments · Fixed by rero/rero-ils-ui#951
Assignees
@Garfield-fr
Labels
client request Issue reported by production libraries correction An implemented feature doesn't work as expected. p-Medium Medium priority (to be solved within 1-2 years) UX User experience, ergonomy

Comments

@PascalRepond
Copy link
Contributor

PascalRepond commented Sep 27, 2022 •
edited
Loading

How it works

In rero-ils-ui, some strings use the i18nPlural pipe. Sometimes, they also include a translate pipe, sometimes not. Either way, these strings are not correctly translated.

Examples: https://ils.test.rero.ch/global/patrons/profile (badge "1 renewal")
https://ilsdev.test.rero.ch/professional/records/patrons/detail/4 ("Phones")

Improvement suggestion

Fix the pipes on these strings so that they can be correctly extracted and translated.
@PascalRepond PascalRepond added f: professional ui Professional interface f: public ui Public interface, as opposed to the professional interface p-Medium Medium priority (to be solved within 1-2 years) UX User experience, ergonomy correction An implemented feature doesn't work as expected. client request Issue reported by production libraries labels Sep 27, 2022
@pronguen pronguen added the translations Translations label Sep 28, 2022
@PascalRepond PascalRepond added the effort: minor Solved quickly label Nov 3, 2022
@Garfield-fr Garfield-fr self-assigned this Mar 8, 2023
Garfield-fr added a commit to Garfield-fr/rero-ils-ui that referenced this issue Mar 8, 2023
@Garfield-fr
translations: fix string translation i18n pipe
1141050 
* Closes rero/rero-ils#3112

Co-Authored-by: Bertrand Zuchuat <[email protected]>
@Garfield-fr Garfield-fr mentioned this issue Mar 8, 2023
Merged
Garfield-fr added a commit to Garfield-fr/rero-ils-ui that referenced this issue Mar 20, 2023
@Garfield-fr
translations: fix string translation i18n pipe
7bb6c8c 
* Closes rero/rero-ils#3112

Co-Authored-by: Bertrand Zuchuat <[email protected]>
Garfield-fr added a commit to rero/rero-ils-ui that referenced this issue Mar 20, 2023
@Garfield-fr
translations: fix string translation i18n pipe
9ba0d70 
* Closes rero/rero-ils#3112

Co-Authored-by: Bertrand Zuchuat <[email protected]>
@PascalRepond PascalRepond removed translations Translations effort: minor Solved quickly f: professional ui Professional interface f: public ui Public interface, as opposed to the professional interface labels Mar 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Garfield-fr Garfield-fr

Labels
client request Issue reported by production libraries correction An implemented feature doesn't work as expected. p-Medium Medium priority (to be solved within 1-2 years) UX User experience, ergonomy
Projects
RERO ILS issues
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

translations: fix string translation i18n pipe Garfield-fr/rero-ils-ui
3 participants
@Garfield-fr @pronguen @PascalRepond