Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Librarians should receive a notification when an item arrives at desk #2695

Closed
ManaDeweerdt opened this issue Feb 10, 2022 · 2 comments · Fixed by #2810
Closed

Librarians should receive a notification when an item arrives at desk #2695

ManaDeweerdt opened this issue Feb 10, 2022 · 2 comments · Fixed by #2810
Assignees
@zannkukai
Labels
enhancement Improvement of an existing feature f: circulation Concerns the circulation interface or backend f: notifications p-High High priority (to be solved in the 2-3 next months)
Milestone
v1.11.0

Comments

@ManaDeweerdt
Copy link
Contributor

ManaDeweerdt commented Feb 10, 2022 •
edited by pronguen
Loading

Describe the bug

For now, the booking notification is sent after a checkin action, when there is a pending loan. This does not completely meet the needs because:

  • the request expiration date cannot always be set in the notification (if the item goes in transit)
  • some libraries want to print a notification at the moment of the request validation rather than at the request creation

Expected behavior

  1. Create a notification at_desk
    • it is sent when a loan arrives "ITEM_AT_DESK" (same condition that triggers the availability notification, with an eventual delay configured)
  2. Add a new template for this notification (see below)
  3. Adapt the library notification settings to add this notification type. As for availability, it should contain the "delay" field.

Difference with the availability notification

  • it is sent to the transaction library, not to the patron
  • the template is different (very similar to booking notification, but completed with the request expiration)

TEMPLATE: at_desk.odt
OVERVIEW OF NOTIFICATION SPEC: spec_impressions.odt
@ManaDeweerdt ManaDeweerdt added f: circulation Concerns the circulation interface or backend f: notifications triage bug Breaks something but is not blocking p-Medium Medium priority (to be solved within 1-2 years) labels Feb 10, 2022
@PascalRepond
Copy link
Contributor

To me, this is not a bug. By definition a transit or booking notification shouldn't happen on request validation. See specs here: https://bib.rero.ch/help/circulation/#notifications-de-circulation
I think this is also what causes misunderstandings in #2707

@pronguen pronguen mentioned this issue Mar 16, 2022
Closed
@pronguen pronguen added enhancement Improvement of an existing feature p-High High priority (to be solved in the 2-3 next months) and removed bug Breaks something but is not blocking p-Medium Medium priority (to be solved within 1-2 years) needs info labels Mar 16, 2022
@pronguen
Copy link
Contributor

This issue has been re-written according to a discussion in the PO group.

@pronguen pronguen added this to the v1.11.0 milestone Mar 16, 2022
@PascalRepond PascalRepond changed the title Transit and booking notification not sent after request validation Librarians should recieve a notification when an item arrives at desk Mar 17, 2022
@zannkukai zannkukai self-assigned this Apr 4, 2022
zannkukai added a commit to zannkukai/rero-ils that referenced this issue Apr 4, 2022
@zannkukai
notification: create 'at_desk' notification
8f7c10d 
When an item arrives 'at_desk' a notification was already sent to the
patron to alert it that the item is now available (availability
notification). A sibling notification is now sent to the transaction
library (at_desk notification) ; mainly for printing usage.

Closes rero#2695.

Co-Authored-by: Renaud Michotte <[email protected]>
@zannkukai zannkukai mentioned this issue Apr 4, 2022
Merged
7 tasks
zannkukai added a commit to zannkukai/rero-ils that referenced this issue Apr 5, 2022
@zannkukai
notification: create 'at_desk' notification
d5173f4 
When an item arrives 'at_desk' a notification was already sent to the
patron to alert it that the item is now available (availability
notification). A sibling notification is now sent to the transaction
library (at_desk notification) ; mainly for printing usage.

Closes rero#2695.

Co-Authored-by: Renaud Michotte <[email protected]>
zannkukai added a commit that referenced this issue Apr 21, 2022
@zannkukai
notification: create 'at_desk' notification
5fafec6 
When an item arrives 'at_desk' a notification was already sent to the
patron to alert it that the item is now available (availability
notification). A sibling notification is now sent to the transaction
library (at_desk notification) ; mainly for printing usage.

Closes #2695.

Co-Authored-by: Renaud Michotte <[email protected]>
zannkukai added a commit that referenced this issue Apr 21, 2022
@zannkukai
notification: create 'at_desk' notification
32641e2 
When an item arrives 'at_desk' a notification was already sent to the
patron to alert it that the item is now available (availability
notification). A sibling notification is now sent to the transaction
library (at_desk notification) ; mainly for printing usage.

Closes #2695.

Co-Authored-by: Renaud Michotte <[email protected]>
zannkukai added a commit to zannkukai/rero-ils that referenced this issue Apr 28, 2022
@zannkukai
notification: create 'at_desk' notification
ea7dd84 
When an item arrives 'at_desk' a notification was already sent to the
patron to alert it that the item is now available (availability
notification). A sibling notification is now sent to the transaction
library (at_desk notification) ; mainly for printing usage.

Closes rero#2695.

Co-Authored-by: Renaud Michotte <[email protected]>
zannkukai added a commit to zannkukai/rero-ils that referenced this issue May 4, 2022
@zannkukai
notification: create 'at_desk' notification
7856d2c 
When an item arrives 'at_desk' a notification was already sent to the
patron to alert it that the item is now available (availability
notification). A sibling notification is now sent to the transaction
library (at_desk notification) ; mainly for printing usage.

Closes rero#2695.

Co-Authored-by: Renaud Michotte <[email protected]>
zannkukai added a commit that referenced this issue May 4, 2022
@zannkukai
notification: create 'at_desk' notification
aeecc25 
When an item arrives 'at_desk' a notification was already sent to the
patron to alert it that the item is now available (availability
notification). A sibling notification is now sent to the transaction
library (at_desk notification) ; mainly for printing usage.

Closes #2695.

Co-Authored-by: Renaud Michotte <[email protected]>
zannkukai added a commit to zannkukai/rero-ils that referenced this issue May 4, 2022
@zannkukai
notification: create 'at_desk' notification
a7f450a 
When an item arrives 'at_desk' a notification was already sent to the
patron to alert it that the item is now available (availability
notification). A sibling notification is now sent to the transaction
library (at_desk notification) ; mainly for printing usage.

Closes rero#2695.

Co-Authored-by: Renaud Michotte <[email protected]>
zannkukai added a commit to zannkukai/rero-ils that referenced this issue May 5, 2022
@zannkukai
notification: create 'at_desk' notification
5881ece 
When an item arrives 'at_desk' a notification was already sent to the
patron to alert it that the item is now available (availability
notification). A sibling notification is now sent to the transaction
library (at_desk notification) ; mainly for printing usage.

Closes rero#2695.

Co-Authored-by: Renaud Michotte <[email protected]>
zannkukai added a commit to zannkukai/rero-ils that referenced this issue May 5, 2022
@zannkukai
notification: create 'at_desk' notification
9b2e10d 
When an item arrives 'at_desk' a notification was already sent to the
patron to alert it that the item is now available (availability
notification). A sibling notification is now sent to the transaction
library (at_desk notification) ; mainly for printing usage.

Closes rero#2695.

Co-Authored-by: Renaud Michotte <[email protected]>
zannkukai added a commit that referenced this issue May 5, 2022
@zannkukai
notification: create 'at_desk' notification
3df885f 
When an item arrives 'at_desk' a notification was already sent to the
patron to alert it that the item is now available (availability
notification). A sibling notification is now sent to the transaction
library (at_desk notification) ; mainly for printing usage.

Closes #2695.

Co-Authored-by: Renaud Michotte <[email protected]>
zannkukai added a commit to zannkukai/rero-ils that referenced this issue May 9, 2022
@zannkukai
notification: create 'at_desk' notification
d677fb8 
When an item arrives 'at_desk' a notification was already sent to the
patron to alert it that the item is now available (availability
notification). A sibling notification is now sent to the transaction
library (at_desk notification) ; mainly for printing usage.

Closes rero#2695.

Co-Authored-by: Renaud Michotte <[email protected]>
zannkukai added a commit to zannkukai/rero-ils that referenced this issue May 9, 2022
@zannkukai
notification: create 'at_desk' notification
214fba8 
When an item arrives 'at_desk' a notification was already sent to the
patron to alert it that the item is now available (availability
notification). A sibling notification is now sent to the transaction
library (at_desk notification) ; mainly for printing usage.

Closes rero#2695.

Co-Authored-by: Renaud Michotte <[email protected]>
zannkukai added a commit to zannkukai/rero-ils that referenced this issue May 10, 2022
@zannkukai
notification: create 'at_desk' notification
cf1a3f8 
When an item arrives 'at_desk' a notification was already sent to the
patron to alert it that the item is now available (availability
notification). A sibling notification is now sent to the transaction
library (at_desk notification) ; mainly for printing usage.

Closes rero#2695.

Co-Authored-by: Renaud Michotte <[email protected]>
BadrAly pushed a commit that referenced this issue May 10, 2022
@zannkukai
notification: create 'at_desk' notification
42083c5 
When an item arrives 'at_desk' a notification was already sent to the
patron to alert it that the item is now available (availability
notification). A sibling notification is now sent to the transaction
library (at_desk notification) ; mainly for printing usage.

Closes #2695.

Co-Authored-by: Renaud Michotte <[email protected]>
zannkukai added a commit that referenced this issue May 12, 2022
@zannkukai
notification: create 'at_desk' notification
bf50fa4 
When an item arrives 'at_desk' a notification was already sent to the
patron to alert it that the item is now available (availability
notification). A sibling notification is now sent to the transaction
library (at_desk notification) ; mainly for printing usage.

Closes #2695.

Co-Authored-by: Renaud Michotte <[email protected]>
@pronguen pronguen changed the title Librarians should recieve a notification when an item arrives at desk Librarians should recEIve a notification when an item arrives at desk May 12, 2022
@PascalRepond PascalRepond changed the title Librarians should recEIve a notification when an item arrives at desk Librarians should recieve a notification when an item arrives at desk May 12, 2022
@pronguen pronguen changed the title Librarians should recieve a notification when an item arrives at desk Librarians should receive a notification when an item arrives at desk May 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@zannkukai zannkukai

Labels
enhancement Improvement of an existing feature f: circulation Concerns the circulation interface or backend f: notifications p-High High priority (to be solved in the 2-3 next months)
Projects
None yet
Milestone
v1.11.0
Development

Successfully merging a pull request may close this issue.

notification: create 'at_desk' notification zannkukai/rero-ils
4 participants
@pronguen @zannkukai @ManaDeweerdt @PascalRepond