Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some due soon notifications are sent too early #2336

Closed
pronguen opened this issue Aug 26, 2021 · 2 comments
Closed

Some due soon notifications are sent too early #2336

pronguen opened this issue Aug 26, 2021 · 2 comments
Labels
bug Breaks something but is not blocking f: notifications p-High High priority (to be solved in the 2-3 next months)

Comments

@pronguen
Copy link
Contributor

pronguen commented Aug 26, 2021

Describe the bug

Some due soon notifications are sent too early. This happened in RBNJ and in RERO+VS, on 25.08.21. It was the date of deployment of the v1.4.7, maybe linked?

To Reproduce

Still unknown, see examples

Expected behavior

The due soon notification is sent as specified in the circulation policy.

Context

Example

Concerned item (pid:3039066) / patron (pid:18251) - vs

Chère lectrice, cher lecteur,

Le délai de prêt des documents mentionnés ci-dessous arrive à échéance :
Titre : Gestion des conflits / Marjorie Danna, Cécile Neuville
Echéance : 18.09.2021

Vous pouvez consulter votre compte et prolonger la durée de prêt de vos documents à l'adresse : https://bib.rero.ch/vs/patrons/profile

Avec nos compliments

SION - Médiathèque Valais
Rue de Lausanne 45, CP 182, CH - 1950 Sion

@pronguen pronguen added f: notifications bug Breaks something but is not blocking p-High High priority (to be solved in the 2-3 next months) labels Aug 26, 2021
@jma
Copy link
Contributor

jma commented Sep 1, 2021

The due soon notification has been created before the renewal and processed after the renewal. We need to be sure to create and process the due soon notification the same day. Here is the creation and modification date of the notification:

     '_created': '2021-08-20T06:54:35.345347+00:00',
     '_updated': '2021-08-25T06:27:54.953917+00:00',

the renewal has been done the 2021-08-21

@iGormilhit
Copy link

Due to failed workers, that are now monitored.

The #2345 is related to this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Breaks something but is not blocking f: notifications p-High High priority (to be solved in the 2-3 next months)
Projects
None yet
Development

No branches or pull requests

3 participants