From 52876d61d8611f9d4f677d3b224d76f53352d7d7 Mon Sep 17 00:00:00 2001
From: Renaud Michotte <renaud.michotte@gmail.com>
Date: Thu, 1 Oct 2020 14:33:18 +0200
Subject: [PATCH] holding: fix holding display problem.

If a document is a serial or electronic, all linked holdings was force
to be displayed as serial/electronic. This PR fix this problem ; despite
of the document metadata, the holding is display depending of the
holding_type metadata from the holding.

Closes rero/rero-ils#1252

Co-Authored-by: Renaud Michotte <renaud.michotte@gmail.com>
---
 .../holding/holding.component.html            |  2 +-
 .../holding/holding.component.ts              |  5 ++--
 .../holdings/holdings.component.html          | 25 +++++++++----------
 3 files changed, 16 insertions(+), 16 deletions(-)

diff --git a/projects/admin/src/app/record/detail-view/document-detail-view/holding/holding.component.html b/projects/admin/src/app/record/detail-view/document-detail-view/holding/holding.component.html
index f4355a688..c1b224fb4 100644
--- a/projects/admin/src/app/record/detail-view/document-detail-view/holding/holding.component.html
+++ b/projects/admin/src/app/record/detail-view/document-detail-view/holding/holding.component.html
@@ -101,7 +101,7 @@
               <div class="col-sm-2" translate>Call number</div>
             </div>
             <admin-default-holding-item
-                *ngFor="let item of items"
+                *ngFor="let item of items | slice:0: displayItemsCounter"
                 class="row mt-1"
                 [holding]="holding"
                 [item]="item"
diff --git a/projects/admin/src/app/record/detail-view/document-detail-view/holding/holding.component.ts b/projects/admin/src/app/record/detail-view/document-detail-view/holding/holding.component.ts
index 894286c55..ec742f26a 100644
--- a/projects/admin/src/app/record/detail-view/document-detail-view/holding/holding.component.ts
+++ b/projects/admin/src/app/record/detail-view/document-detail-view/holding/holding.component.ts
@@ -30,8 +30,8 @@ export class HoldingComponent implements OnInit, OnDestroy {
   /** Holding record */
   @Input() holding: any;
 
-  /** Document harvested */
-  @Input() holdingType: 'electronic' | 'serial' | 'standard';
+  /** shortcut for holding type */
+  holdingType: 'electronic' | 'serial' | 'standard';
 
   /** Items */
   items: any = null;
@@ -70,6 +70,7 @@ export class HoldingComponent implements OnInit, OnDestroy {
 
   /** Init */
   ngOnInit() {
+    this.holdingType = this.holding.metadata.holdings_type;
     if (this.holdingType !== 'electronic') {
       this._loadItems();
     }
diff --git a/projects/admin/src/app/record/detail-view/document-detail-view/holdings/holdings.component.html b/projects/admin/src/app/record/detail-view/document-detail-view/holdings/holdings.component.html
index db46432f6..a51cd9288 100644
--- a/projects/admin/src/app/record/detail-view/document-detail-view/holdings/holdings.component.html
+++ b/projects/admin/src/app/record/detail-view/document-detail-view/holdings/holdings.component.html
@@ -15,21 +15,20 @@
   along with this program.  If not, see <http://www.gnu.org/licenses/>.
 -->
 
-  <div class="row" *ngIf="canAdd">
-    <div class="col" [ngSwitch]="holdingType">
-      <a *ngSwitchCase="'standard'" class="btn btn-sm btn-outline-primary mt-2 float-right"
-        [routerLink]="['/', 'records', 'items', 'new']" [queryParams]="{ document: documentPid }">
-        <i class="fa fa-plus-square-o"></i> {{ 'Add' | translate }}...
-      </a>
-      <a *ngSwitchCase="'serial'" class="btn btn-sm btn-outline-primary float-right"
-        [routerLink]="['/', 'records', 'holdings', 'new']" [queryParams]="{ document: documentPid }">
-        <i class="fa fa-plus-square-o"></i> {{ 'Add' | translate }}...
-      </a>
-    </div>
+<div class="row" *ngIf="canAdd">
+  <div class="col" [ngSwitch]="holdingType">
+    <a *ngSwitchCase="'standard'" class="btn btn-sm btn-outline-primary mt-2 float-right"
+      [routerLink]="['/', 'records', 'items', 'new']" [queryParams]="{ document: documentPid }">
+      <i class="fa fa-plus-square-o"></i> {{ 'Add' | translate }}...
+    </a>
+    <a *ngSwitchCase="'serial'" class="btn btn-sm btn-outline-primary float-right"
+      [routerLink]="['/', 'records', 'holdings', 'new']" [queryParams]="{ document: documentPid }">
+      <i class="fa fa-plus-square-o"></i> {{ 'Add' | translate }}...
+    </a>
   </div>
+</div>
 
 <ng-container *ngIf="holdings">
-  <admin-document-holding *ngFor="let holding of holdings" [holding]="holding" [holdingType]="holdingType"
-    (deleteHolding)="deleteHolding($event)">
+  <admin-document-holding *ngFor="let holding of holdings" [holding]="holding" (deleteHolding)="deleteHolding($event)">
   </admin-document-holding>
 </ng-container>