fix: certain texts get unselected on keystroke #1033
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Garfield-fr
force-pushed
the
zub-unselected-text-fix
branch
2 times, most recently
from
da65662 to
e830cc6
Compare
PascalRepond
approved these changes
Aug 29, 2023
jma
approved these changes
Aug 29, 2023
| /** process provision activity publications */ | ||
| private processProvisionActivityPublications() { | ||
| const { provisionActivity } = this.record.metadata; | ||
| if (undefined === provisionActivity) { |
There was a problem hiding this comment.
Why not if (provisionActivity === undefined)?
| * @param element: the element to check | ||
| * @return True if element isn't a 'Publication', False otherwise | ||
| */ | ||
| filterNotPublicationProvisionActivity(element: any): boolean { |
zannkukai
approved these changes
Aug 29, 2023
|
|
||
| @Input() record: any; | ||
|
|
||
| cartographicAttributes: any[] = []; |
There was a problem hiding this comment.
Missing "bored" docstring...
* Closes rero/rero-ils#3276. Co-Authored-by: Bertrand Zuchuat <[email protected]>
Garfield-fr
force-pushed
the
zub-unselected-text-fix
branch
from
e830cc6 to
463cd4d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Code review check list